kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-5937) Improve ProcessorStateManager exception handling
Date Tue, 19 Sep 2017 23:26:00 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matthias J. Sax updated KAFKA-5937:
-----------------------------------
    Description: 
We identified the follow issues:

- constructor calls {{StateDirectory#directoryForTask() }} and wraps throw ProcessorStateException
with LockException and rethrows -> we should not change the exception type here
- {{ProcessorStateManager#flush()}} loops through all stores and calls {{StateStore#flush()}};
it stops on first {{Exception}} -> we should keep looping and flush all remaining stores
before rethrowing at the end


  was:
We identified the follow issues:

- constructor calls {{StateDirectory#directoryForTask() }} and wraps throw ProcessorStateException
with LockException and rethrows -> we should not change the exception type here
- {{ProcessorStateManager#close()}} loops through all stores and calls {{StateStore#close()}};
it catches {{Exception}} and moves on to close all stores -> rethrows first exception eventually
as-is -> we should wrap with {{ProcessotStateException}} before rethrowing
- {{ProcessorStateManager#flush()}} loops through all stores and calls {{StateStore#flush()}};
it stops on first {{Exception}} -> we should keep looping and flush all remaining stores
before rethrowing at the end



> Improve ProcessorStateManager exception handling
> ------------------------------------------------
>
>                 Key: KAFKA-5937
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5937
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>    Affects Versions: 0.11.0.0, 0.11.0.1
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>             Fix For: 1.0.0
>
>
> We identified the follow issues:
> - constructor calls {{StateDirectory#directoryForTask() }} and wraps throw ProcessorStateException
with LockException and rethrows -> we should not change the exception type here
> - {{ProcessorStateManager#flush()}} loops through all stores and calls {{StateStore#flush()}};
it stops on first {{Exception}} -> we should keep looping and flush all remaining stores
before rethrowing at the end



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message