kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5928) Avoid redundant requests to zookeeper when reassign topic partition
Date Mon, 25 Sep 2017 01:04:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178423#comment-16178423
] 

ASF GitHub Bot commented on KAFKA-5928:
---------------------------------------

Github user uncleGen closed the pull request at:

    https://github.com/apache/kafka/pull/3894


> Avoid redundant requests to zookeeper when reassign topic partition
> -------------------------------------------------------------------
>
>                 Key: KAFKA-5928
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5928
>             Project: Kafka
>          Issue Type: Improvement
>          Components: admin
>    Affects Versions: 0.10.2.1, 0.11.0.0
>            Reporter: Genmao Yu
>
> We mistakenly request topic level information according to partitions config in the assignment
json file. For example https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala#L550:
>  {code}
> val validPartitions = proposedPartitionAssignment.filter { case (p, _) => validatePartition(zkUtils,
p.topic, p.partition) } 
> {code} 
> If reassign 1000 partitions (in 10 topics), we need to request zookeeper 1000 times here.
But actually we only need to request just 10 (topics) times. We test a large-scale assignment,
about 10K partitions. It takes tens of minutes. After optimization, it will reduce to less
than 1minute.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message