kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5914) Return MessageFormatVersion and MessageMaxBytes in MetadataResponse
Date Tue, 19 Sep 2017 06:10:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171163#comment-16171163
] 

ASF GitHub Bot commented on KAFKA-5914:
---------------------------------------

GitHub user apurvam opened a pull request:

    https://github.com/apache/kafka/pull/3896

    KAFKA-5914 add message format version and message max bytes to metadata response

    Updated the `TopicResponse` part of the `MetadataResponse` to include the message format
version and the message max bytes.
    
    One problem here is that we use the `TopicConfigHandler` to listen for topic changes.
However this is not invoked for topic _creates_ since the change notification path is not
updated during creates. I am not sure what the right solution is here. Intuitively, we should
update the the change notification path for topic creates, but not sure if that has compatibility
(or other) implications.
    
    TODO:
    1. Add a more complete integration test where the client sends a real `MetadataRequest`
and receives the proper `MetadataResponse`.
    2. Rebase to incorporate Jason's changes.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apurvam/kafka KAFKA-5914-add-message-format-version-and-message-max-bytes-to-metadata-response

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3896.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3896
    
----
commit 7cc943c30be8bef4646580f19e5191ef7e476b98
Author: Apurva Mehta <apurva@confluent.io>
Date:   2017-09-19T04:29:00Z

    Initial commit with a few tests

commit 5099d5163b071020cc627b6b0a7c4f388de99eaa
Author: Apurva Mehta <apurva@confluent.io>
Date:   2017-09-19T06:05:43Z

    Added one more test

----


> Return MessageFormatVersion and MessageMaxBytes in MetadataResponse
> -------------------------------------------------------------------
>
>                 Key: KAFKA-5914
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5914
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Apurva Mehta
>            Assignee: Apurva Mehta
>             Fix For: 1.0.0
>
>
> As part of KIP-192, we want to send two additional fields in the {{TopicMetadata}} which
is part of the {{MetadataResponse}}. These fields are the {{MessageFormatVersion}} and the
{{MessageMaxBytes}}.
> The {{MessageFormatVersion}} is required to implement https://issues.apache.org/jira/browse/KAFKA-5794
. The latter will be implemented in a future release, but with the changes proposed here,
the said future release will be backward compatible with 1.0.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message