kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5899) Create Connect metrics for connectors
Date Thu, 14 Sep 2017 22:46:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167077#comment-16167077
] 

ASF GitHub Bot commented on KAFKA-5899:
---------------------------------------

GitHub user rhauch opened a pull request:

    https://github.com/apache/kafka/pull/3864

    KAFKA-5899 Added Connect metrics for connectors

    Added metrics for each connector using Kafka’s existing `Metrics` framework. Since this
is the first of several changes to add several groups of metrics, this change starts by adding
a very simple `ConnectMetrics` object that is owned by each worker and that makes it easy
to define multiple groups of metrics, called `ConnectMetricGroup` objects. Each metric group
maps to a JMX MBean, and each metric within the group maps to an MBean attribute.
    
    Future PRs will build upon this simple pattern to add metrics for source and sink tasks,
workers, and worker rebalances.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rhauch/kafka kafka-5899

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3864
    
----
commit 02da9b0ebaa9df70c0dfb34799d3a08b051b9570
Author: Randall Hauch <rhauch@gmail.com>
Date:   2017-09-13T14:48:14Z

    KAFKA-5899 Added Connect metrics for connectors
    
    Added metrics for each connector using Kafka’s existing `Metrics` framework. Since this
is the first of several changes to add several groups of metrics, this change starts by adding
a very simple `ConnectMetrics` object that is owned by each worker and that makes it easy
to define multiple groups of metrics, called `ConnectMetricGroup` objects. Each metric group
maps to a JMX MBean, and each metric within the group maps to an MBean attribute.
    
    Future PRs will build upon this simple pattern to add metrics for source and sink tasks,
workers, and worker rebalances.

----


> Create Connect metrics for connectors
> -------------------------------------
>
>                 Key: KAFKA-5899
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5899
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: KafkaConnect
>    Affects Versions: 0.11.0.0
>            Reporter: Randall Hauch
>            Assignee: Randall Hauch
>            Priority: Critical
>             Fix For: 1.0.0
>
>
> See KAFKA-2376 for parent task and [KIP-196|https://cwiki.apache.org/confluence/display/KAFKA/KIP-196%3A+Add+metrics+to+Kafka+Connect+framework]
for the details on the metrics. This subtask is to create the "Connect Metrics", and a basic
framework for easily adding other Connect metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message