kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5820) Remove unneeded synchronized keyword in StreamThread
Date Fri, 08 Sep 2017 00:11:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157901#comment-16157901
] 

ASF GitHub Bot commented on KAFKA-5820:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/3777


> Remove unneeded synchronized keyword in StreamThread
> ----------------------------------------------------
>
>                 Key: KAFKA-5820
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5820
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> There are three methods in StreamThread which have unnecessary synchronized keyword since
the variable accessed, state, is volatile :
> isRunningAndNotRebalancing
> isRunning
> shutdown
> synchronized keyword can be dropped for these methods.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message