kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Cheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5738) Add cumulative count attribute for all Kafka rate metrics
Date Sun, 17 Sep 2017 07:57:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169222#comment-16169222
] 

James Cheng commented on KAFKA-5738:
------------------------------------

The PR for this forgot to add the new Sender metrics to getAllTemplates() method, which means
we won't have autogenerated docs for those metrics. https://github.com/apache/kafka/blame/8a5e86660593eab49c64fdfb5ef090634ae5ae06/clients/src/main/java/org/apache/kafka/clients/producer/internals/SenderMetricsRegistry.java#L111

It's an easy mistake to make, since there is unfortunately no automatic way to keep that list
in sync with the actual metrics.

Should I submit a PR to add those in? Or [~rsivaram], would you like to do it?

> Add cumulative count attribute for all Kafka rate metrics
> ---------------------------------------------------------
>
>                 Key: KAFKA-5738
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5738
>             Project: Kafka
>          Issue Type: New Feature
>          Components: metrics
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>             Fix For: 1.0.0
>
>
> Add cumulative count attribute to all Kafka rate metrics to make downstream processing
simpler, more accurate, and more flexible.
>  
> See [KIP-187|https://cwiki.apache.org/confluence/display/KAFKA/KIP-187+-+Add+cumulative+count+metric+for+all+Kafka+rate+metrics]
for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message