kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paolo Patierno (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5723) Refactor BrokerApiVersionsCommand to use AdminClient
Date Thu, 07 Sep 2017 14:30:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157009#comment-16157009

Paolo Patierno commented on KAFKA-5723:

[~adyachkov] [~viktorsomogyi] the discussion on how to handle this is going on the mailing
list. What [~ijuma] is proposing is to have small PRs against the trunk so that the committers
can check and merge them easily.
My idea is the following :

* Then [KAFKA-3268|https://issues.apache.org/jira/browse/KAFKA-3268] can be used as umbrella
for our works on different components
* For sure we have some common components (i.e. CommandOptions). My idea is to get my CommandOptions
class and the suggestion from [~adyachkov] (from his PR) and then making a PR with just it
and some other changes
* Then you and committers can review the PR
* When the PR will be merged we can continue on our different works refactoring the different

Does it make sense to you ?

> Refactor BrokerApiVersionsCommand to use AdminClient
> ----------------------------------------------------
>                 Key: KAFKA-5723
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5723
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Viktor Somogyi
>            Assignee: Viktor Somogyi
> Currently it uses the deprecated AdminClient and in order to remove usages of that client,
this class needs to be refactored.

This message was sent by Atlassian JIRA

View raw message