kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5541) Streams should not re-throw if suspending/closing tasks fails
Date Mon, 25 Sep 2017 01:30:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16178433#comment-16178433
] 

ASF GitHub Bot commented on KAFKA-5541:
---------------------------------------

GitHub user mjsax opened a pull request:

    https://github.com/apache/kafka/pull/3953

    KAFKA-5541: Streams should not re-throw if suspending/closing tasks fails

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjsax/kafka kafka-5541-dont-rethrow-on-suspend-or-close

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3953
    
----
commit c662e9c3bf970ddce5e319d5a3645c780079f554
Author: Matthias J. Sax <matthias@confluent.io>
Date:   2017-09-25T01:27:44Z

    KAFKA-5541: Streams should not re-throw if suspending/closing tasks fails

----


> Streams should not re-throw if suspending/closing tasks fails
> -------------------------------------------------------------
>
>                 Key: KAFKA-5541
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5541
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>             Fix For: 1.0.0
>
>
> Currently, if Stream suspends a task on rebalance or closes a suspended task that got
revoked, it re-throws any exception that might occur and the thread dies. However, this in
not really necessary as the task was suspended/closed anyway and we can just clean up the
task and carry on with the rebalance.
> (cf comments https://github.com/apache/kafka/pull/3449#discussion_r124437816)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message