kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5515) Consider removing date formatting from Segments class
Date Mon, 18 Sep 2017 11:14:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169888#comment-16169888

ASF GitHub Bot commented on KAFKA-5515:

Github user asfgit closed the pull request at:


> Consider removing date formatting from Segments class
> -----------------------------------------------------
>                 Key: KAFKA-5515
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5515
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Bill Bejeck
>            Assignee: Damian Guy
>              Labels: performance
>             Fix For: 1.0.0
> Currently the {{Segments}} class uses a date when calculating the segment id and uses
{{SimpleDateFormat}} for formatting the segment id.  However this is a high volume code path
and creating a new {{SimpleDateFormat}} and formatting each segment id is expensive.  We should
look into removing the date from the segment id or at a minimum use a faster alternative to
{{SimpleDateFormat}}.  We should also consider keeping a lookup of existing segments to avoid
as many string operations as possible.

This message was sent by Atlassian JIRA

View raw message