kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5301) Improve exception handling on consumer path
Date Wed, 13 Sep 2017 22:39:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165405#comment-16165405

ASF GitHub Bot commented on KAFKA-5301:

GitHub user ConcurrencyPractitioner reopened a pull request:


    KAFKA-5301 Improve exception handling on consumer path

    This is an improvised approach towards fixing @guozhangwang 's second issue. 
    I have changed the method return type as well as override such that it returns exception.
    If the exception returned is not null (the default value), than we skip the callback.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ConcurrencyPractitioner/kafka trunk

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3842
commit 6290df2070f215d0b355f3e59717d911e50b8973
Author: Richard Yu <richardyu@richards-air.attlocal.net>
Date:   2017-09-13T03:19:24Z

    [Kafka-5301] Improve exception handling on consumer path

commit 3a01de2d4e293d15da5c390bc5179243bbdb833e
Author: Richard Yu <richardyu@richards-air.attlocal.net>
Date:   2017-09-13T22:34:11Z

    Exception handling add-on


> Improve exception handling on consumer path
> -------------------------------------------
>                 Key: KAFKA-5301
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5301
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>    Affects Versions:
>            Reporter: Eno Thereska
>             Fix For: 1.0.0
>         Attachments: 5301.v1.patch
> Used in StreamsThread.java, mostly to .poll() but also to restore data.
> Used in StreamsTask.java, mostly to .pause(), .resume()
> All exceptions here are currently caught all the way up to the main running loop in a
broad catch(Exception e) statement in StreamThread.run().
> One main concern on the consumer path is handling deserialization errors that happen
before streams has even had a chance to look at the data: https://issues.apache.org/jira/browse/KAFKA-5157

This message was sent by Atlassian JIRA

View raw message