kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-5185) Adding the RecordMetadata that is returned by the producer to the commitRecord method for SourceTask
Date Sat, 23 Sep 2017 04:49:06 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-5185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Guozhang Wang updated KAFKA-5185:
---------------------------------

*Reminder to the contributor / reviewer of the PR*: please note that the code deadline for
1.0.0 is less than 2 weeks away (Oct. 4th). Please re-evaluate your JIRA and see if it still
makes sense to be merged into 1.0.0 or it could be pushed out to 1.1.0, or be closed directly
if the JIRA itself is not valid any more, or re-assign yourself as contributor / committer
if you are no longer working on the JIRA.

> Adding the RecordMetadata that is returned by the producer to the commitRecord method
for SourceTask
> ----------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5185
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5185
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>            Reporter: George Smith
>             Fix For: 1.0.0
>
>
> An improvement request I thought would be useful.
> Added the producers record metadata object to the commitRecord method on the SourceTask
class so more data is provided from the producer and it allows anyone overriding and hooking
into the commitRecord method to receive more information about where the record was procuded
to. 
> Left the old commitRecord method with just the sourcerecord for backwards compatbility
even though this would technically be included in a new version of kafka, it would intoduce
a breaking change without it. 
> Opened up PR here: https://github.com/apache/kafka/pull/2989



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message