kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3999) Consumer bytes-fetched metric uses decompressed message size
Date Fri, 22 Sep 2017 00:04:01 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175686#comment-16175686
] 

ASF GitHub Bot commented on KAFKA-3999:
---------------------------------------

GitHub user vahidhashemian opened a pull request:

    https://github.com/apache/kafka/pull/3941

    KAFKA-3999: Record raw size of fetch responses as part of consumer metrics

    Currently, only the decompressed size of fetch responses is recorded. This PR adds a sensor
to keep track of the raw size as well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vahidhashemian/kafka KAFKA-3999

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3941
    
----
commit 0eb84a3c83530081748d4bf9ffe7fcba9e41f50b
Author: Vahid Hashemian <vahidhashemian@us.ibm.com>
Date:   2017-09-22T00:01:48Z

    KAFKA-3999: Record raw size of fetch responses as part of consumer metrics
    
    Currently, only the decompressed size of fetch responses is recorded. This PR adds a sensor
to keep track of the raw size as well.

----


> Consumer bytes-fetched metric uses decompressed message size
> ------------------------------------------------------------
>
>                 Key: KAFKA-3999
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3999
>             Project: Kafka
>          Issue Type: Bug
>          Components: consumer
>    Affects Versions: 0.9.0.1, 0.10.0.0
>            Reporter: Jason Gustafson
>            Assignee: Vahid Hashemian
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> It looks like the computation for the bytes-fetched metrics uses the size of the decompressed
message set. I would have expected it to be based off of the raw size of the fetch responses.
Perhaps it would be helpful to expose both the raw and decompressed fetch sizes? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message