kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-3832) Kafka Connect's JSON Converter never outputs a null value
Date Thu, 07 Sep 2017 20:57:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157640#comment-16157640
] 

Ted Yu commented on KAFKA-3832:
-------------------------------

Isn't the following doing what you describe ?
{code}
    private static JsonNode convertToJson(Schema schema, Object logicalValue) {
        if (logicalValue == null) {
            if (schema == null) // Any schema is valid and we don't have a default, so treat
this as an optional schema
                return null;
{code}

> Kafka Connect's JSON Converter never outputs a null value
> ---------------------------------------------------------
>
>                 Key: KAFKA-3832
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3832
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.9.0.1
>            Reporter: Randall Hauch
>              Labels: newbie
>
> Kafka Connect's JSON Converter will never output a null value when {{enableSchemas=true}}.
This means that when a connector outputs a {{SourceRecord}} with a null value, the JSON Converter
will always produce a message value with:
> {code:javascript}
> {
>   "schema": null,
>   "payload": null
> }
> {code}
> And, this means that while Kafka log compaction will always be able to remove earlier
messages with the same key, log compaction will never remove _all_ of the messages with the
same key. 
> The JSON Connector's {{fromConnectData(...)}} should always return null when it is supplied
a null value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message