Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A190C20049D for ; Wed, 9 Aug 2017 15:02:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A028B169186; Wed, 9 Aug 2017 13:02:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E780D169181 for ; Wed, 9 Aug 2017 15:02:03 +0200 (CEST) Received: (qmail 57311 invoked by uid 500); 9 Aug 2017 13:02:03 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 57300 invoked by uid 99); 9 Aug 2017 13:02:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Aug 2017 13:02:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B5592C4119 for ; Wed, 9 Aug 2017 13:02:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id y6UrlvJb1feN for ; Wed, 9 Aug 2017 13:02:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 78F1E5FC3A for ; Wed, 9 Aug 2017 13:02:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BB54CE0997 for ; Wed, 9 Aug 2017 13:02:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 477A82415E for ; Wed, 9 Aug 2017 13:02:00 +0000 (UTC) Date: Wed, 9 Aug 2017 13:02:00 +0000 (UTC) From: "Damian Guy (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (KAFKA-5717) [streams] 'null' values in state stores MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 09 Aug 2017 13:02:04 -0000 [ https://issues.apache.org/jira/browse/KAFKA-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Damian Guy reassigned KAFKA-5717: --------------------------------- Assignee: Damian Guy > [streams] 'null' values in state stores > --------------------------------------- > > Key: KAFKA-5717 > URL: https://issues.apache.org/jira/browse/KAFKA-5717 > Project: Kafka > Issue Type: Bug > Components: streams > Affects Versions: 0.10.2.1, 0.11.0.0 > Reporter: Bart Vercammen > Assignee: Damian Guy > > When restoring the state on an in-memory KeyValue store (at startup of the Kafka Streams application), the _deleted_ values are put in the store as _key_ with _value_ {{null}} instead of being removed from the store. > (this happens when the underlying kafka topic segment did not get compacted yet) > After some digging I came across this in {{InMemoryKeyValueStore}}: > {code} > public synchronized void put(K key, V value) { > this.map.put(key, value); > } > {code} > I would assume this implementation misses the check on {{value}} being {{null}} to *delete* the entry instead of just storing it. > In the RocksDB implementation it is done correctly: > {code} > if (rawValue == null) { > try { > db.delete(wOptions, rawKey); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)