Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7388E200CD8 for ; Wed, 2 Aug 2017 19:04:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 70F54169E44; Wed, 2 Aug 2017 17:04:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B86BF169E45 for ; Wed, 2 Aug 2017 19:04:03 +0200 (CEST) Received: (qmail 96201 invoked by uid 500); 2 Aug 2017 17:04:03 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 96190 invoked by uid 99); 2 Aug 2017 17:04:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Aug 2017 17:04:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 69D94C02AA for ; Wed, 2 Aug 2017 17:04:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id gIkSmfPVlxqo for ; Wed, 2 Aug 2017 17:04:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 1C87D5F5B3 for ; Wed, 2 Aug 2017 17:04:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65DCFE0012 for ; Wed, 2 Aug 2017 17:04:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 10A0321ED9 for ; Wed, 2 Aug 2017 17:04:00 +0000 (UTC) Date: Wed, 2 Aug 2017 17:04:00 +0000 (UTC) From: "Tom Bentley (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-5693) TopicCreationPolicy and AlterConfigsPolicy overlap MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 02 Aug 2017 17:04:04 -0000 [ https://issues.apache.org/jira/browse/KAFKA-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111313#comment-16111313 ] Tom Bentley commented on KAFKA-5693: ------------------------------------ One (obvious) part solution to this is that the {{CreateTopicPolicy}} should be applied not just at topic creation, but also for every topic modification, whether it's a change to the topic configs or something else. Unless there's a valid use case for configuring changed topics differently to freshly created topics? By symmetry, unless it's OK for a noop topic config change to be rejected by the {{AlterConfigPolicy}}, maybe the topic config supplied during topic creation should also be run through the {{AlterConfigPolicy}}. Again, maybe there are valid use cases for allowing a topic config at creation which would be disallowed in a later modification, but I can't think of any. > TopicCreationPolicy and AlterConfigsPolicy overlap > -------------------------------------------------- > > Key: KAFKA-5693 > URL: https://issues.apache.org/jira/browse/KAFKA-5693 > Project: Kafka > Issue Type: Bug > Reporter: Tom Bentley > Priority: Minor > > The administrator of a cluster can configure a {{CreateTopicPolicy}}, which has access to the topic configs as well as other metadata to make its decision about whether a topic creation is allowed. Thus in theory the decision could be based on a combination of of the replication factor, and the topic configs, for example. > Separately there is an AlterConfigPolicy, which only has access to the configs (and can apply to configurable entities other than just topics). > There are potential issues with this. For example although the CreateTopicPolicy is checked at creation time, it's not checked for any later alterations to the topic config. So policies which depend on both the topic configs and other topic metadata could be worked around by changing the configs after creation. -- This message was sent by Atlassian JIRA (v6.4.14#64029)