kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5763) Refactor NetworkClient to use LogContext
Date Wed, 30 Aug 2017 19:41:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147901#comment-16147901
] 

ASF GitHub Bot commented on KAFKA-5763:
---------------------------------------

GitHub user adyach opened a pull request:

    https://github.com/apache/kafka/pull/3761

    KAFKA-5763: Refactor NetworkClient to use LogContext

    This PR lets logging client id in every log line in NetworkClient

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adyach/kafka kafka-5763

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3761.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3761
    
----
commit 4b1b42ffed8394c3dfb6412989cec7a82277bc94
Author: Andrey Dyachkov <andrey.dyachkov@gmail.com>
Date:   2017-08-30T19:38:15Z

    kafka-5763: LogConotext to creatre logger with prefix
    
    This PR lets logging client id in every log line in NetworkClient

----


> Refactor NetworkClient to use LogContext
> ----------------------------------------
>
>                 Key: KAFKA-5763
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5763
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ismael Juma
>             Fix For: 1.0.0
>
>
> We added a LogContext object which automatically adds a log prefix to every message written
by loggers constructed from it (much like the Logging mixin available in the server code).
We use this in the consumer to ensure that messages always contain the consumer group and
client ids, which is very helpful when multiple consumers are run on the same instance. We
should do something similar for the NetworkClient. We should always include the client id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message