kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5762) Refactor AdminClient to use LogContext
Date Fri, 25 Aug 2017 14:53:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141709#comment-16141709
] 

ASF GitHub Bot commented on KAFKA-5762:
---------------------------------------

GitHub user Kamal15 opened a pull request:

    https://github.com/apache/kafka/pull/3741

    KAFKA-5762; LogContext used to capture the clientId implicitly in the…

    … logs.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Kamal15/kafka kafka-5762

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3741.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3741
    
----
commit 274a9688a004f63b74a8997f84082456e45fe785
Author: Kamal Chandraprakash <kamal.chandraprakash@gmail.com>
Date:   2017-08-25T14:46:57Z

    KAFKA-5762; LogContext used to capture the clientId implicitly in the logs.

----


> Refactor AdminClient to use LogContext
> --------------------------------------
>
>                 Key: KAFKA-5762
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5762
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ismael Juma
>            Assignee: Kamal Chandraprakash
>
> We added a LogContext object which automatically adds a log prefix to every message written
by loggers constructed from it (much like the Logging mixin available in the server code).
We use this in the consumer to ensure that messages always contain the consumer group and
client ids, which is very helpful when multiple consumers are run on the same instance. We
should do something similar for the AdminClient. We should always include the client id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message