kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5754) Refactor Streams to use LogContext
Date Thu, 24 Aug 2017 09:00:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139784#comment-16139784
] 

ASF GitHub Bot commented on KAFKA-5754:
---------------------------------------

GitHub user umesh9794 opened a pull request:

    https://github.com/apache/kafka/pull/3727

    KAFKA-5754 : Refactor Streams to use LogContext

    This PR utilizes `org.apache.kafka.common.utils.LogContext` for logging in `KafkaStreams`.
@hachikuji, @ijuma please review this and let me know your thoughts. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/umesh9794/kafka KAFKA-5754

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3727
    
----
commit 7560e473cd17c522c2e3b2aba6d83ffdadeeffab
Author: umesh chaudhary <umesh9794@gmail.com>
Date:   2017-08-24T08:53:03Z

    KAFKA-5754 : Refactor Streams to use LogContext

----


> Refactor Streams to use LogContext
> ----------------------------------
>
>                 Key: KAFKA-5754
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5754
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Jason Gustafson
>            Assignee: Umesh Chaudhary
>              Labels: newbie
>
> We added a {{LogContext}} object which automatically adds a log prefix to every message
written by loggers constructed from it (much like the Logging mixin available in the server
code). We use this in the consumer to ensure that messages always contain the consumer group
and client ids, which is very helpful when multiple consumers are run on the same instance.
Kafka Streams requires similar contextual logging by including the prefix manually in each
log message. It would be better to take advantage of the new {{LogContext}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message