kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5726) KafkaConsumer.subscribe() overload that takes just Pattern without ConsumerRebalanceListener
Date Tue, 15 Aug 2017 09:21:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126987#comment-16126987
] 

ASF GitHub Bot commented on KAFKA-5726:
---------------------------------------

GitHub user attilakreiner opened a pull request:

    https://github.com/apache/kafka/pull/3669

    KAFKA-5726: KafkaConsumer.subscribe() overload that takes just Pattern

    - changed the interface & implementations
    - updated tests to use the new method where applicable

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/attilakreiner/kafka KAFKA-5726

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3669
    
----
commit 8e7b6e741f0ad042421ada39e0c9c1546d231bfb
Author: Attila Kreiner <attila@kreiner.hu>
Date:   2017-08-14T20:56:21Z

    KAFKA-5726: KafkaConsumer.subscribe() overload that takes just Pattern

----


> KafkaConsumer.subscribe() overload that takes just Pattern without ConsumerRebalanceListener
> --------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5726
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5726
>             Project: Kafka
>          Issue Type: Improvement
>          Components: consumer
>    Affects Versions: 0.11.0.0
>            Reporter: Yeva Byzek
>            Priority: Minor
>              Labels: needs-kip, newbie, usability
>
> Request: provide {{subscribe(Pattern pattern)}} overload, similar to {{subscribe(Collection<String>
topics)}}, 
> Today, for a consumer to subscribe to topics based on a regular expression (i.e. {{Pattern}}),
the only method option also requires to pass in a {{ConsumerRebalanceListener}}. This is not
user-friendly to require this second argument. It seems {{new NoOpConsumerRebalanceListener()}}
has to be used.  
> Use case: multi datacenter, allowing easier subscription to multiple topics prefixed
with datacenter names, just by using a pattern subscription.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message