kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paolo Patierno (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (KAFKA-5684) KStreamPrintProcessor as customized KStreamPeekProcessor
Date Fri, 04 Aug 2017 16:08:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114563#comment-16114563
] 

Paolo Patierno edited comment on KAFKA-5684 at 8/4/17 4:07 PM:
---------------------------------------------------------------

Just to add that the {{KStreamPrint}} needs to be aware of the mapper (null or not) so it
means that even if removing the mapper from the {{PrintForeachAction}} constructor we need
to add it to the {{KStreamPrint}} constructor so that in the {{init}} method we can set it
to the {{PrintForeachAction}} or creating and then setting the default one.

Btw I'm going to do in your way, which makes more sense to me.


was (Author: ppatierno):
Just to add that the {{KStreamPrint}} needs to be aware of the mapper (null or not) so it
means that even if removing the mapper from the {{PrintForeachAction}} constructor we need
to add it to the {{KStreamPrint}} constructor so that in the {{init}} method we can set it
to the {{PrintForeachAction}} or creating and then setting the default one.

> KStreamPrintProcessor as customized KStreamPeekProcessor
> --------------------------------------------------------
>
>                 Key: KAFKA-5684
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5684
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Paolo Patierno
>            Assignee: Paolo Patierno
>            Priority: Minor
>
> Hi,
> the {{KStreamPrintProcessor}} is implemented from scratch (from the {{AbstractProcessor}})
and the same for the related supplier.
> It looks to me that it's just a special {{KStreamPeekProcessor}} with forwardDownStream
to false and that allows the possibility to specify Serdes instances used if key/values are
bytes.
> At same time used by a {{print()}} method it provides a fast way to print data flowing
through the pipeline (while using just {{peek()}} you need to write the code).
> I think that it could be useful to refactoring the {{KStreamPrintProcessor}} as derived
from the {{KStreamPeekProcessor}} customizing its behavior.
> Thanks,
> Paolo.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message