kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5679) Add logging to distinguish between internally and externally initiated shutdown of Kafka
Date Tue, 15 Aug 2017 07:57:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126907#comment-16126907
] 

ASF GitHub Bot commented on KAFKA-5679:
---------------------------------------

GitHub user rajinisivaram opened a pull request:

    https://github.com/apache/kafka/pull/3668

    KAFKA-5679: Add logging for broker termination due to SIGTERM or SIGINT

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rajinisivaram/kafka KAFKA-5679

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3668.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3668
    
----
commit e6f02a6eb90c242d850d3aab2e59d74162d88626
Author: rajini <rajini@192.168.0.22>
Date:   2017-08-15T07:29:49Z

    KAFKA-5679: Add logging for broker termination due to SIGTERM or SIGINT

----


> Add logging to distinguish between internally and externally initiated shutdown of Kafka
> ----------------------------------------------------------------------------------------
>
>                 Key: KAFKA-5679
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5679
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.11.0.0
>            Reporter: Apurva Mehta
>            Assignee: Apurva Mehta
>             Fix For: 1.0.0
>
>
> Currently, if there is an internal error that triggers a shutdown of the Kafka server,
the {{Exit}} class is used, which begins the shutdown procedure. The other way a shutdown
is triggered is by {{SIGTERM}} or some other signal.
> We would like to distinguish between shutdown due to internal errors and external signals.
This helps when debugging. Particularly, a natural question when a broker shuts down unexpectedly
is:  "did the deployment system send the signal or is there some un logged fatal error in
the broker"? 
> Today, we rely on callers of {{Exit}} to log the error before making the call. However,
this won't always have 100% coverage. It would be good to add a log message in {{Exit}} to
record that an exit method was invoked explicitly. 
> We could also add a signal handler to log when {{SIGTERM}}, {{SIGKILL}} etc. are received.
> This would make operating Kafka a bit easier.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message