kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4915) Don't include "error" in log messages at non-error levels
Date Mon, 28 Aug 2017 19:55:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144256#comment-16144256
] 

ASF GitHub Bot commented on KAFKA-4915:
---------------------------------------

GitHub user dernasherbrezon opened a pull request:

    https://github.com/apache/kafka/pull/3751

    KAFKA-4915: do not use word "error" while logging with non-error level

    Normally if logging event is an error, then it should have log level "ERROR". If it's
not an error, it should not have "Error" in the log message.
    
    So I changed wordings a bit.
    
    Also I've deliberately skipped several places, where error is the actual entity name received/sent.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dernasherbrezon/kafka KAFKA-4915

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3751.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3751
    
----
commit b3a3bc49196ad48c45daaa67d5c0263f22742552
Author: dernasherbrezon <rodionovamp@mail.ru>
Date:   2017-08-28T19:50:30Z

    KAFKA-4915: do not use word "error" while logging with non-error level

----


> Don't include "error" in log messages at non-error levels
> ---------------------------------------------------------
>
>                 Key: KAFKA-4915
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4915
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.1.1
>            Reporter: Andrey
>
> Currently we see in logs:
> {code}
> WARN Error while fetching metadata with correlation id 659455 : {kafka-connect-offsets=INVALID_REPLICATION_FACTOR}
(org.apache.kafka.clients.NetworkClient:600)
> {code}
> Expected:
> {code}
> WARN unable to fetch metadata with correlation id 659455 : {kafka-connect-offsets=INVALID_REPLICATION_FACTOR}
(org.apache.kafka.clients.NetworkClient:600)
> {code}
> or
> {code}
> ERROR unable to fetch metadata with correlation id 659455 : {kafka-connect-offsets=INVALID_REPLICATION_FACTOR}
(org.apache.kafka.clients.NetworkClient:600)
> {code}
> See for reference: https://github.com/apache/kafka/blob/65650ba4dcba8a9729cb9cb6477a62a7b7c3714e/clients/src/main/java/org/apache/kafka/clients/NetworkClient.java#L723



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message