kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manikumar (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (KAFKA-1675) bootstrapping tidy-up
Date Tue, 29 Aug 2017 20:25:00 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Manikumar resolved KAFKA-1675.
------------------------------
    Resolution: Fixed

 gradlew, gradlew.bat scripts are removed from repo. Pl reopen if you think the issue still
exists


> bootstrapping tidy-up
> ---------------------
>
>                 Key: KAFKA-1675
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1675
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Szczepan Faber
>            Assignee: Ivan Lyutov
>         Attachments: KAFKA-1675.patch
>
>
> I'd like to suggest following changes:
> 1. remove the 'gradlew' and 'gradlew.bat' scripts from the source tree. Those scripts
don't work, e.g. they fail with exception when invoked. I just got a user report where those
scripts were invoked by the user and it led to an exception that was not easy to grasp. Bootstrapping
step will generate those files anyway.
> 2. move the 'gradleVersion' extra property from the 'build.gradle' into 'gradle.properties'.
Otherwise it is hard to automate the bootstrapping process - in order to find out the gradle
version, I need to evaluate the build script, and for that I need gradle with correct version
(kind of a vicious circle). Project properties declared in the gradle.properties file can
be accessed exactly the same as the 'ext' properties, for example: 'project.gradleVersion'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message