Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@kafka.apache.org
Date: Sun, 30 Jul 2017 10:22:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: jira@kafka.apache.org
Message-ID: <JIRA.13007409.1474778295000.46112.1501410120355@Atlassian.JIRA>
In-Reply-To: <JIRA.13007409.1474778295000@Atlassian.JIRA>
References: <JIRA.13007409.1474778295000@Atlassian.JIRA> <JIRA.13007409.1474778295223@jira-lw-us.apache.org>
Subject: [jira] [Commented] (KAFKA-4218) Enable access to key in
 ValueTransformer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 30 Jul 2017 10:22:05 -0000


    [ https://issues.apache.org/jira/browse/KAFKA-4218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106421#comment-16106421 ] 

ASF GitHub Bot commented on KAFKA-4218:
---------------------------------------

GitHub user jeyhunkarimov opened a pull request:

    https://github.com/apache/kafka/pull/3598

    KAFKA-4218: Add withkey methods to KStream

    This PR aims to add withKey methods to KStream interface. 
    This PR is part of [KIP-149](https://cwiki.apache.org/confluence/display/KAFKA/KIP-149%3A+Enabling+key+access+in+ValueTransformer%2C+ValueMapper%2C+and+ValueJoiner).
    I separated the complete PR into 4 parts as discussed in [here](https://github.com/apache/kafka/pull/3570#issuecomment-317645747). So, this PR concentrates on adding withKey methods to KStream interface. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jeyhunkarimov/kafka KIP-149_KStream

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3598.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3598
    
----
commit c37be59024ea7fd69e1a8ffe2bae1272c3035aec
Author: Jeyhun Karimov <je.karimov@gmail.com>
Date:   2017-07-28T23:25:59Z

    Add withkey interfaces
    
    Add withkey interfaces
    
    Add withKey converters in AbstractStream
    
    Add KStream withKey interfaces
    
    Remove unnecessary lines

----


> Enable access to key in ValueTransformer
> ----------------------------------------
>
>                 Key: KAFKA-4218
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4218
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions: 0.10.0.1
>            Reporter: Elias Levy
>            Assignee: Jeyhun Karimov
>              Labels: api, kip
>             Fix For: 1.0.0
>
>
> While transforming values via {{KStream.transformValues}} and {{ValueTransformer}}, the key associated with the value may be needed, even if it is not changed.  For instance, it may be used to access stores.  
> As of now, the key is not available within these methods and interfaces, leading to the use of {{KStream.transform}} and {{Transformer}}, and the unnecessary creation of new {{KeyValue}} objects.
> KIP-149: https://cwiki.apache.org/confluence/display/KAFKA/KIP-149%3A+Enabling+key+access+in+ValueTransformer%2C+ValueMapper%2C+and+ValueJoiner


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)