kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guozhang Wang (JIRA)" <j...@apache.org>
Subject [jira] [Created] (KAFKA-5676) MockStreamsMetrics should be in o.a.k.test
Date Fri, 28 Jul 2017 23:05:01 GMT
Guozhang Wang created KAFKA-5676:
------------------------------------

             Summary: MockStreamsMetrics should be in o.a.k.test
                 Key: KAFKA-5676
                 URL: https://issues.apache.org/jira/browse/KAFKA-5676
             Project: Kafka
          Issue Type: Bug
          Components: streams
            Reporter: Guozhang Wang


{{MockStreamsMetrics}}'s package should be `o.a.k.test` not `o.a.k.streams.processor.internals`.


In addition, it should not require a {{Metrics}} parameter in its constructor as it is only
needed for its extended base class; the right way of mocking should be implementing {{StreamsMetrics}}
with mock behavior than extended a real implementaion of {{StreamsMetricsImpl}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message