kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5664) Disable auto offset commit in ConsoleConsumer if no group is provided
Date Fri, 28 Jul 2017 21:52:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105744#comment-16105744
] 

ASF GitHub Bot commented on KAFKA-5664:
---------------------------------------

GitHub user vahidhashemian opened a pull request:

    https://github.com/apache/kafka/pull/3593

    KAFKA-5664: Disable auto offset commit in ConsoleConsumer if no group is provided

    This is to avoid polluting the Consumer Coordinator cache as the auto-generated group
and its offsets are unlikely to be reused.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vahidhashemian/kafka KAFKA-5664

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3593.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3593
    
----
commit 3d708fabb7609de794fc90c86c4fb00d47118fb5
Author: Vahid Hashemian <vahidhashemian@us.ibm.com>
Date:   2017-07-28T21:47:45Z

    KAFKA-5664: Disable auto offset commit in ConsoleConsumer if no group is provided
    
    This is to avoid polluting the Consumer Coordinator cache as the group and its offsets
are unlikely to be reused.

----


> Disable auto offset commit in ConsoleConsumer if no group is provided
> ---------------------------------------------------------------------
>
>                 Key: KAFKA-5664
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5664
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jason Gustafson
>            Assignee: Vahid Hashemian
>
> In ConsoleCosnumer, if no group is provided, we generate a random groupId:
> {code}
> consumerProps.put(ConsumerConfig.GROUP_ID_CONFIG, s"console-consumer-${new Random().nextInt(100000)}")
> {code}
> In this case, since the group is not likely to be used again, we should disable automatic
offset commits. This avoids polluting the coordinator cache with offsets that will never be
used.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message