kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paolo Patierno (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5536) Tools splitted between Java and Scala implementation
Date Mon, 10 Jul 2017 10:58:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080163#comment-16080163
] 

Paolo Patierno commented on KAFKA-5536:
---------------------------------------

Hi [~ijuma], 

I have opened a PR on https://issues.apache.org/jira/browse/KAFKA-5561 just for evaluation
if we agree on that path for refactoring the first tool, TopicCommand, from Scala to Java
and
at same time using the Admin client API.
Regarding the command line arguments parsing I used the joptsimple lib as already used in
the Scala version even if I see that the few
Java tools are using argparse4j. With joptsimple the transition from Scala to Java is smooth
and the logic could be the same.
I see that the original TopicCommand uses some utilities classes from the "core" (CommandLineUtils
and CoreUtils for example).
I rewrote the CommandLineUtils in Java (putting it inside the "tools") but I was wondering
if we should reuse the Scala one; in this
case we should add the "core" as dependecy on "tools". I have a doubt about that.

Can you take a look at that, please ? 

> Tools splitted between Java and Scala implementation
> ----------------------------------------------------
>
>                 Key: KAFKA-5536
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5536
>             Project: Kafka
>          Issue Type: Wish
>            Reporter: Paolo Patierno
>
> Hi,
> is there any specific reason why tools are splitted between Java and Scala implementations
?
> Maybe it could be better having only one language for all of them.
> What do you think ?
> Thanks,
> Paolo



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message