kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5531) Check exception handling in all streams tests
Date Tue, 04 Jul 2017 11:58:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073527#comment-16073527
] 

ASF GitHub Bot commented on KAFKA-5531:
---------------------------------------

GitHub user evis opened a pull request:

    https://github.com/apache/kafka/pull/3485

    KAFKA-5531: throw concrete exceptions in streams tests

    1. Now instead of just generic Exception methods declare more concrete
    exceptions throwing or don't declare any throwing at all, if not needed.
    2. SimpleBenchmark.run() throws RuntimeException
    3. SimpleBenchmark.produce() throws IllegalArgumentException
    4. Expect ProcessorStateException in
    StandbyTaskTest.testUpdateNonPersistentStore()
    
    /cc @enothereska 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/evis/kafka 5531-throw-concrete-exceptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3485
    
----
commit 2bdfe2807f42b225e398e06aa1fdc3002b271b1c
Author: Evgeny Veretennikov <evg.veretennikov@gmail.com>
Date:   2017-07-04T11:57:00Z

    KAFKA-5531: throw concrete exceptions in streams tests
    
    1. Now instead of just generic Exception methods declare more concrete
    exceptions throwing or don't declare any throwing at all, if not needed.
    2. SimpleBenchmark.run() throws RuntimeException
    3. SimpleBenchmark.produce() throws IllegalArgumentException
    4. Expect ProcessorStateException in
    StandbyTaskTest.testUpdateNonPersistentStore()

----


> Check exception handling in all streams tests
> ---------------------------------------------
>
>                 Key: KAFKA-5531
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5531
>             Project: Kafka
>          Issue Type: Sub-task
>          Components: streams
>    Affects Versions: 0.11.0.0
>            Reporter: Eno Thereska
>            Assignee: Evgeny Veretennikov
>             Fix For: 0.11.0.1
>
>
> In some stream unit and integration tests, we sometimes suffix a test with "throws Exception"
which is overly broad and in some cases can mask a real bug. Instread we should be throwing
a narrower exception, e.g., "throws IOException".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message