kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michal Borowiecki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5233) Changes to punctuate semantics (KIP-138)
Date Sat, 29 Jul 2017 09:41:03 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106084#comment-16106084
] 

Michal Borowiecki commented on KAFKA-5233:
------------------------------------------

Yes, my line of thinking was that although deprecated, the old punctuate still has to work
so it would be better not to lose test coverage for it. I'll raise a ticket to eventually
remove the deprecated punctuate method and that feels to me like the natural time to also
remove associated unit tests.

On the other hand, if you found any unit tests that I had missed, let me know which tests
those are and I'll add equivalent tests for the new punctuate method.

> Changes to punctuate semantics (KIP-138)
> ----------------------------------------
>
>                 Key: KAFKA-5233
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5233
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Michal Borowiecki
>            Assignee: Michal Borowiecki
>              Labels: kip
>             Fix For: 1.0.0
>
>
> This ticket is to track implementation of 
> [KIP-138: Change punctuate semantics|https://cwiki.apache.org/confluence/display/KAFKA/KIP-138%3A+Change+punctuate+semantics]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message