kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ismael Juma (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (KAFKA-4459) rat license check not running in Jenkins
Date Tue, 25 Jul 2017 11:12:04 GMT

     [ https://issues.apache.org/jira/browse/KAFKA-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ismael Juma updated KAFKA-4459:
-------------------------------
    Fix Version/s:     (was: 1.0.0)

> rat license check not running in Jenkins
> ----------------------------------------
>
>                 Key: KAFKA-4459
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4459
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Ismael Juma
>            Assignee: Ewen Cheslack-Postava
>             Fix For: 0.11.0.0
>
>
> The following commit introduced files without a license, which causes rat to fail when
run locally:
> https://github.com/apache/kafka/commit/e035fc039598127e88f31739458f705290b1fdba
> However, the build passed in Jenkins:
> https://builds.apache.org/job/kafka-trunk-jdk7/1710/
> Not sure why, but a potential culprit is the check for `.git` in the build:
> {code}
> if (new File('.git').exists()) {
>   apply from: file('gradle/rat.gradle')
>   rat {
>     // Exclude everything under the directory that git should be ignoring via .gitignore
or that isn't checked in. These
>     // restrict us only to files that are checked in or are staged.
>     def repo = Grgit.open(project.file('.'))
>     excludes = new ArrayList<String>(repo.clean(ignore: false, directories: true,
dryRun: true))
>     // And some of the files that we have checked in should also be excluded from this
check
>     excludes.addAll([
>         '**/.git/**',
>         '**/build/**',
>         'CONTRIBUTING.md',
>         'gradlew',
>         'gradlew.bat',
>         '**/README.md'
>     ])
>   }
> }
> {code}
> If the current directory in Jenkins is not the repo directory, it could fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message