Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6FD2A200CDA for ; Fri, 30 Jun 2017 01:43:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6C870160BED; Thu, 29 Jun 2017 23:43:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AFB33160BF7 for ; Fri, 30 Jun 2017 01:43:08 +0200 (CEST) Received: (qmail 64914 invoked by uid 500); 29 Jun 2017 23:43:06 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 64903 invoked by uid 99); 29 Jun 2017 23:43:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jun 2017 23:43:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5ACB61AF948 for ; Thu, 29 Jun 2017 23:43:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id jDUHkSSI0Mft for ; Thu, 29 Jun 2017 23:43:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E0B735FBBA for ; Thu, 29 Jun 2017 23:43:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B0632E06CF for ; Thu, 29 Jun 2017 23:43:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1724B245A9 for ; Thu, 29 Jun 2017 23:43:02 +0000 (UTC) Date: Thu, 29 Jun 2017 23:43:02 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-5543) We don't remove the LastStableOffsetLag metric when a partition is moved away from a broker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 29 Jun 2017 23:43:09 -0000 [ https://issues.apache.org/jira/browse/KAFKA-5543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069198#comment-16069198 ] ASF GitHub Bot commented on KAFKA-5543: --------------------------------------- GitHub user apurvam opened a pull request: https://github.com/apache/kafka/pull/3462 KAFKA-5543: Remove all partition metrics when a topic is deleted You can merge this pull request into a Git repository by running: $ git pull https://github.com/apurvam/kafka KAFKA-5543-remove-lastStableOffsetLag-metric Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3462.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3462 ---- commit f315bbdcd0a26755db1a7169822279f8965c5309 Author: Apurva Mehta Date: 2017-06-29T23:41:58Z Remove all partition metrics when a topic is deleted ---- > We don't remove the LastStableOffsetLag metric when a partition is moved away from a broker > ------------------------------------------------------------------------------------------- > > Key: KAFKA-5543 > URL: https://issues.apache.org/jira/browse/KAFKA-5543 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.11.0.0 > Reporter: Apurva Mehta > Assignee: Apurva Mehta > Fix For: 0.11.0.1 > > > Reported by [~junrao], we have a small leak where the `LastStableOffsetLag` metric is not removed along with the other metrics in the `Partition.removeMetrics` method. This could create a leak when partitions are reassigned or a topic is deleted. -- This message was sent by Atlassian JIRA (v6.4.14#64029)