Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9F24A200CB0 for ; Fri, 23 Jun 2017 18:45:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9E8A2160BE5; Fri, 23 Jun 2017 16:45:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E4F4F160BE2 for ; Fri, 23 Jun 2017 18:45:02 +0200 (CEST) Received: (qmail 17866 invoked by uid 500); 23 Jun 2017 16:45:02 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 17851 invoked by uid 99); 23 Jun 2017 16:45:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jun 2017 16:45:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B1A9F1A0904 for ; Fri, 23 Jun 2017 16:45:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id B_EskstleedN for ; Fri, 23 Jun 2017 16:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D566E5F46F for ; Fri, 23 Jun 2017 16:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 65D7FE03EE for ; Fri, 23 Jun 2017 16:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2312521943 for ; Fri, 23 Jun 2017 16:45:00 +0000 (UTC) Date: Fri, 23 Jun 2017 16:45:00 +0000 (UTC) From: "Guozhang Wang (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-5379) ProcessorContext.appConfigs() should return parsed/validated values MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 23 Jun 2017 16:45:03 -0000 [ https://issues.apache.org/jira/browse/KAFKA-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061203#comment-16061203 ] Guozhang Wang commented on KAFKA-5379: -------------------------------------- [~twbecker] Could we make a pass over all the Type.CLASS configs in StreamsConfig and make sure users can either pass in a class name (for this case we should document that users any customized class with external dependency will not be supported as we are only relying on reflections) or class object, and the {{appConfigs}} can return the parsed objects as always in this JIRA? Also note that we are adding a few more class typed configs cc [~enothereska] for serialization exception handler, we need to do the same for them. > ProcessorContext.appConfigs() should return parsed/validated values > ------------------------------------------------------------------- > > Key: KAFKA-5379 > URL: https://issues.apache.org/jira/browse/KAFKA-5379 > Project: Kafka > Issue Type: Bug > Components: streams > Affects Versions: 0.10.2.1 > Reporter: Tommy Becker > Assignee: Tommy Becker > Priority: Minor > > As part of KAFKA-5334, it was decided that the current behavior of {{ProcessorContext.appConfigs()}} is sub-optimal in that it returns the original unparsed config values. Alternatively, the parsed values could be returned which would allow callers to know what they are getting as well avoid duplicating type conversions (e.g. className -> class). -- This message was sent by Atlassian JIRA (v6.4.14#64029)