Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CE677200CBF for ; Sat, 24 Jun 2017 03:03:03 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CD48E160BF2; Sat, 24 Jun 2017 01:03:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1FEC2160BE5 for ; Sat, 24 Jun 2017 03:03:02 +0200 (CEST) Received: (qmail 20444 invoked by uid 500); 24 Jun 2017 01:03:02 -0000 Mailing-List: contact jira-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@kafka.apache.org Delivered-To: mailing list jira@kafka.apache.org Received: (qmail 20432 invoked by uid 99); 24 Jun 2017 01:03:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Jun 2017 01:03:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C475D1A0193 for ; Sat, 24 Jun 2017 01:03:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.001 X-Spam-Level: X-Spam-Status: No, score=-100.001 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 2YBWoXmxVBqs for ; Sat, 24 Jun 2017 01:03:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D43FA5F368 for ; Sat, 24 Jun 2017 01:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6F75AE06C6 for ; Sat, 24 Jun 2017 01:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 27D332193E for ; Sat, 24 Jun 2017 01:03:00 +0000 (UTC) Date: Sat, 24 Jun 2017 01:03:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: jira@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (KAFKA-4829) Improve logging of StreamTask commits MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 24 Jun 2017 01:03:04 -0000 [ https://issues.apache.org/jira/browse/KAFKA-4829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061708#comment-16061708 ] ASF GitHub Bot commented on KAFKA-4829: --------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/kafka/pull/3354 > Improve logging of StreamTask commits > ------------------------------------- > > Key: KAFKA-4829 > URL: https://issues.apache.org/jira/browse/KAFKA-4829 > Project: Kafka > Issue Type: Improvement > Components: streams > Affects Versions: 0.10.2.0 > Reporter: Steven Schlansker > Priority: Minor > Labels: user-experience > > Currently I see this every commit interval: > {code} > 2017-02-28T21:27:16.659Z INFO <> [StreamThread-1] o.a.k.s.p.internals.StreamThread - stream-thread [StreamThread-1] Committing task StreamTask 1_31 > 2017-02-28T21:27:16.659Z INFO <> [StreamThread-1] o.a.k.s.p.internals.StreamThread - stream-thread [StreamThread-1] Committing task StreamTask 2_31 > {code} > We have ~10 tasks in our topology, 4 topics, and 32 partitions per topic. > This means every commit interval we log a few hundred lines of the above > which is an order of magnitude chattier than anything else in the log > during normal operations. > To improve visibility of important messages, we should reduce the chattiness of normal commits and highlight abnormal commits. An example proposal: > existing message is fine at TRACE level for diagnostics > {{TRACE o.a.k.s.p.i.StreamThread - Committing task StreamTask 1_31}} > normal fast case, wrap them all up into one summary line > {{INFO o.a.k.s.p.i.StreamThreads - 64 stream tasks committed in 25ms}} > some kind of threshold / messaging in case it doesn't complete quickly or logs an exception > {{ERROR o.a.k.s.p.i.StreamThread - StreamTask 1_32 did not commit in 100ms}} -- This message was sent by Atlassian JIRA (v6.4.14#64029)