kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5485) Streams should not suspend tasks twice
Date Wed, 21 Jun 2017 02:14:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056847#comment-16056847

ASF GitHub Bot commented on KAFKA-5485:

GitHub user mjsax opened a pull request:


    KAFKA-5485: Streams should not suspend tasks twice


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjsax/kafka kafka-5485-dont-suspend-tasks-twice

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3390
commit 467fd514ac9310dc6a17473fd7f8d9a62d4c1a5c
Author: Matthias J. Sax <matthias@confluent.io>
Date:   2017-06-21T02:08:49Z

    KAFKA-5485: Streams should not suspend tasks twice


> Streams should not suspend tasks twice
> --------------------------------------
>                 Key: KAFKA-5485
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5485
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>    Affects Versions:
>            Reporter: Matthias J. Sax
>            Assignee: Matthias J. Sax
>            Priority: Minor
> Currently, Streams suspends tasks on rebalance and closes suspended tasks if not reassigned.
During close, {{suspend()}} is called a second time, also calling {{Processor.close()}} for
all nodes again.
> It would be safer to only call {{suspend()}} once in case users have non-idempotent operations
in {{Processor.close()}} method and might thus fail. (cf. KAFKA-5167)

This message was sent by Atlassian JIRA

View raw message