kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tommy Becker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-5379) ProcessorContext.appConfigs() should return parsed/validated values
Date Wed, 28 Jun 2017 12:18:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066393#comment-16066393
] 

Tommy Becker commented on KAFKA-5379:
-------------------------------------

Hey [~guozhang], I should have a PR ready pretty soon, this just slipped off my radar. One
thing that slightly complicates this change is that currently, users can put arbitrary values
in the config map at topology build time, and later retrieve them via {{ProcessorContext.appConfigs()}}.
If we change that to return {{StreamsConfig.values()}}, this will no longer be possible. So
I changed {{ProcessorContext.appConfigs()}} to return a Map that has the parsed values overlaid
on the originals. So it contains the parsed values for known configs but other unknown values
are still there.

> ProcessorContext.appConfigs() should return parsed/validated values
> -------------------------------------------------------------------
>
>                 Key: KAFKA-5379
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5379
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams
>    Affects Versions: 0.10.2.1
>            Reporter: Tommy Becker
>            Assignee: Tommy Becker
>            Priority: Minor
>
> As part of KAFKA-5334, it was decided that the current behavior of {{ProcessorContext.appConfigs()}}
is sub-optimal in that it returns the original unparsed config values. Alternatively, the
parsed values could be returned which would allow callers to know what they are getting as
well avoid duplicating type conversions (e.g. className -> class).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message