kafka-jira mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (KAFKA-4388) Connect key and value converters are listed without default values
Date Mon, 26 Jun 2017 13:51:00 GMT

    [ https://issues.apache.org/jira/browse/KAFKA-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063107#comment-16063107
] 

ASF GitHub Bot commented on KAFKA-4388:
---------------------------------------

GitHub user evis opened a pull request:

    https://github.com/apache/kafka/pull/3435

    KAFKA-4388 Recommended values for converters from plugins

    Questions to reviewers:
    1. Should we cache `converterRecommenders.validValues()`, `SinkConnectorConfig.configDef()`
and `SourceConnectorConfig.configDef()` results?
    2. What is appropriate place for testing new `ConnectorConfig.configDef(plugins)` functionality?
    
    cc @ewencp 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/evis/kafka converters_values

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3435
    
----
commit 069a1ba832f844c20224598c622fa19576b0ba61
Author: Evgeny Veretennikov <evg.veretennikov@gmail.com>
Date:   2017-06-26T13:44:40Z

    KAFKA-4388 Recommended values for converters from plugins
    
    ConnectorConfig.configDef() takes Plugins parameter now. List of
    recommended values for converters is taken from plugins.converters()

----


> Connect key and value converters are listed without default values
> ------------------------------------------------------------------
>
>                 Key: KAFKA-4388
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4388
>             Project: Kafka
>          Issue Type: Bug
>          Components: KafkaConnect
>    Affects Versions: 0.10.1.0
>            Reporter: Ewen Cheslack-Postava
>            Assignee: Evgeny Veretennikov
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> KIP-75 added per connector converters. This exposes the settings on a per-connector basis
via the validation API. However, the way this is specified for each connector is via a config
value with no default value. This means the validation API implies there is no setting unless
you provide one.
> It would be much better to include the default value extracted from the WorkerConfig
instead so it's clear you shouldn't need to override the default.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message