From dev-return-118558-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Wed Oct 7 17:06:07 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-he-de.apache.org (mxout1-he-de.apache.org [95.216.194.37]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 19CB5180644 for ; Wed, 7 Oct 2020 19:06:07 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-he-de.apache.org (ASF Mail Server at mxout1-he-de.apache.org) with SMTP id 8B75164DB7 for ; Wed, 7 Oct 2020 17:06:04 +0000 (UTC) Received: (qmail 42563 invoked by uid 500); 7 Oct 2020 17:06:02 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 42481 invoked by uid 99); 7 Oct 2020 17:06:02 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Oct 2020 17:06:02 +0000 Received: from jira2-he-de.apache.org (static.54.33.119.168.clients.your-server.de [168.119.33.54]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E8896428BE for ; Wed, 7 Oct 2020 17:06:01 +0000 (UTC) Received: from jira2-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira2-he-de.apache.org (ASF Mail Server at jira2-he-de.apache.org) with ESMTP id 4F066C81E9F for ; Wed, 7 Oct 2020 17:06:00 +0000 (UTC) Date: Wed, 7 Oct 2020 17:06:00 +0000 (UTC) From: "Guozhang Wang (Jira)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (KAFKA-10122) Consumer should allow heartbeat during rebalance as well MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/KAFKA-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-10122. ----------------------------------- Fix Version/s: 2.6.1 2.7.0 Resolution: Fixed > Consumer should allow heartbeat during rebalance as well > -------------------------------------------------------- > > Key: KAFKA-10122 > URL: https://issues.apache.org/jira/browse/KAFKA-10122 > Project: Kafka > Issue Type: Improvement > Reporter: Guozhang Wang > Assignee: Guozhang Wang > Priority: Major > Fix For: 2.7.0, 2.6.1 > > > Today we disable heartbeats if the {{state != MemberState.STABLE}}. And if a rebalance failed we set the state to UNJOINED. In the old API {{poll(long)}} it is okay since we always try to complete the rebalance successfully within the same call, so we would not be in UNJOINED or REBALANCING for a very long time. > But with the new {{poll(Duration)}} we may actually return while we are still in UNJOINED or REBALANCING and it may take some time (smaller than max.poll.interval but larger than session.timeout) before the next poll call, and since heartbeat is disabled during this period of time we could be kicked by the coordinator. > The proposal I have is > 1) allow heartbeat to be sent during REBALANCING as well. > 2) when join/sync response has retriable error, do not set the state to UNJOINED but stay with REBALANCING. -- This message was sent by Atlassian Jira (v8.3.4#803005)