From dev-return-117830-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Fri Sep 11 17:14:25 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 5C90418063F for ; Fri, 11 Sep 2020 19:14:25 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 44B71123B9D for ; Fri, 11 Sep 2020 17:14:23 +0000 (UTC) Received: (qmail 67110 invoked by uid 500); 11 Sep 2020 17:14:22 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 67089 invoked by uid 99); 11 Sep 2020 17:14:22 -0000 Received: from spamproc1-he-de.apache.org (HELO spamproc1-he-de.apache.org) (116.203.196.100) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Sep 2020 17:14:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamproc1-he-de.apache.org (ASF Mail Server at spamproc1-he-de.apache.org) with ESMTP id 6CD7F1FF402 for ; Fri, 11 Sep 2020 17:14:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamproc1-he-de.apache.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.2, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamproc1-he-de.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent.io Received: from mx1-he-de.apache.org ([116.203.227.195]) by localhost (spamproc1-he-de.apache.org [116.203.196.100]) (amavisd-new, port 10024) with ESMTP id x_ABxPzkfbZB for ; Fri, 11 Sep 2020 17:14:20 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::1032; helo=mail-pj1-x1032.google.com; envelope-from=bob.barrett@confluent.io; receiver= Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id B919F7F665 for ; Fri, 11 Sep 2020 17:14:20 +0000 (UTC) Received: by mail-pj1-x1032.google.com with SMTP id kk9so1998219pjb.2 for ; Fri, 11 Sep 2020 10:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=5r1QbdGZ1yu+NjYeKD3ayVqsWEziDfcQuiSfp8LNljo=; b=XzlMVU76tPz5v5zLwywYtWYYUdwKT/s2ISm6iQpZZOtDU8sMmhIhMKToDCV5oVsuzX OCN1xEWEOEsgGpDXdG250wN+17mXpui7/Zr4BclH5vkmMdWwB1f72D54uDOhXR3qh1bm N5ptwkZmKCP8JtBUHkC17U3O2SukSjWiT9Z52emSPhDr7rVxewK5EgX23B7+INXx1ivH nrMFfQbwTwirv2+nXuy1bKNxVBnoktNttsnYA8AxLg5kRTgayZ2hia3ExGS+RzZFaMIV lGXSE/mEDgZWblnWttroSSKxvjPfvrS6a/F2Rx28ymbk6NF1m+z4crqA9RN+yhGkaSFW 5Www== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=5r1QbdGZ1yu+NjYeKD3ayVqsWEziDfcQuiSfp8LNljo=; b=BUAbKIBCVxJ6mBS3vVXqI5RqRIvJCkHa3hUhyCaTQGwFdo+Hwnq/JSNmb2ESmBAIgM 4nkJIY2ARrn/KuDzDl26sZbBSsOyFR7np3Wk/G8ln6y4Ryo6SVAN6N026kbiJGdwngv0 GZpsdtTutoKSuvi1lVolypL2EAfzt7S/B64E9WIOxbSZYBHoaZTYIhxxFymn630jPBMD /RYGvgVQ1bNY9/Rne+anTos+kJrY5UQTO3tXgRKUpuNRHM008cJuqZRGY3FrbtZbxQV5 ebuTKZ4S0Xawv11K9uOfxWuFQweYl+rGdj5URaEQqnPIXS3FCIsYshkJDq4sXEq8I+/V BriA== X-Gm-Message-State: AOAM531oL5H3INGXID1RtSEV27zAVNqazUT7hVYeIASCbrvCeifPdozw Xw1eURM2prM5K6SVizCImr2w7mpx1cEE/qNBKH3a8MOMk8U= X-Google-Smtp-Source: ABdhPJzLKBVh0zyFUi2ghQCm2flTNr0GRNfbWZTbpqdbxThWFEyHx+xwQpaNd9j3S++aCMEcZX8+kEtX5WemV7I2T8A= X-Received: by 2002:a17:90a:f010:: with SMTP id bt16mr3009704pjb.143.1599844452287; Fri, 11 Sep 2020 10:14:12 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Robert Barrett Date: Fri, 11 Sep 2020 10:14:01 -0700 Message-ID: Subject: Re: [DISCUSS] KIP-660: Pluggable ReplicaAssignor To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="00000000000046945105af0cd084" --00000000000046945105af0cd084 Content-Type: text/plain; charset="UTF-8" Thanks Mickael, I think adding the new Exception resolves my concerns. On Thu, Sep 3, 2020 at 9:47 AM Mickael Maison wrote: > Thanks Robert and Ryanne for the feedback. > > ReplicaAssignor implementations can throw an exception to indicate an > assignment can't be computed. This is already what the current round > robin assignor does. Unfortunately at the moment, there are no generic > error codes if it fails, it's either INVALID_PARTITIONS, > INVALID_REPLICATION_FACTOR or worse UNKNOWN_SERVER_ERROR. > > So I think it would be nice to introduce a new Exception/Error code to > cover any failures in the assignor and avoid UNKNOWN_SERVER_ERROR. > > I've updated the KIP accordingly, let me know if you have more questions. > > On Fri, Aug 28, 2020 at 4:49 PM Ryanne Dolan > wrote: > > > > Thanks Mickael, the KIP makes sense to me, esp for cases where an > external > > system (like cruise control or an operator) knows more about the target > > cluster state than the broker does. > > > > Ryanne > > > > On Thu, Aug 20, 2020, 10:46 AM Mickael Maison > > wrote: > > > > > Hi, > > > > > > I've created KIP-660 to make the replica assignment logic pluggable. > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-660%3A+Pluggable+ReplicaAssignor > > > > > > Please take a look and let me know if you have any feedback. > > > > > > Thanks > > > > --00000000000046945105af0cd084--