kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias J. Sax" <mj...@apache.org>
Subject Re: [VOTE] KIP-671: Add method to Shutdown entire Streams Application
Date Wed, 30 Sep 2020 01:10:53 GMT
Thanks Walker. The proposed API changes LGTM.

+1 (binding)

One minor nit: you should also mention the global-thread that also needs
to be shutdown if requested by the user.

Minor side question: should we actually terminate a thread and create a
new one, or instead revive the existing thread (reusing its existing ID)?


-Matthias

On 9/29/20 2:39 PM, Bill Bejeck wrote:
> Thanks for the KIP Walker.
> 
> +1 (binding)
> 
> -Bill
> 
> On Tue, Sep 29, 2020 at 4:59 PM Guozhang Wang <wangguoz@gmail.com> wrote:
> 
>> +1 again on the KIP.
>>
>> On Tue, Sep 29, 2020 at 1:51 PM Leah Thomas <lthomas@confluent.io> wrote:
>>
>>> Hey Walker,
>>>
>>> Thanks for the KIP! I'm +1, non-binding.
>>>
>>> Cheers,
>>> Leah
>>>
>>> On Tue, Sep 29, 2020 at 1:56 PM Walker Carlson <wcarlson@confluent.io>
>>> wrote:
>>>
>>>> Hello all,
>>>>
>>>> I made some changes to the KIP the descriptions are on the discussion
>>>> thread. If you have already voted I would ask you to confirm your vote.
>>>>
>>>> Otherwise please vote so we can get this feature in.
>>>>
>>>> Thanks,
>>>> Walker
>>>>
>>>> On Thu, Sep 24, 2020 at 4:36 PM John Roesler <vvcephei@apache.org>
>>> wrote:
>>>>
>>>>> Thanks for the KIP, Walker!
>>>>>
>>>>> I’m +1 (binding)
>>>>>
>>>>> -John
>>>>>
>>>>> On Mon, Sep 21, 2020, at 17:04, Guozhang Wang wrote:
>>>>>> Thanks for finalizing the KIP. +1 (binding)
>>>>>>
>>>>>>
>>>>>> Guozhang
>>>>>>
>>>>>> On Mon, Sep 21, 2020 at 1:38 PM Walker Carlson <
>>> wcarlson@confluent.io>
>>>>>> wrote:
>>>>>>
>>>>>>> Hello all,
>>>>>>>
>>>>>>> I would like to start a thread to vote for KIP-671 to add a
>> method
>>> to
>>>>> close
>>>>>>> all clients in a kafka streams application.
>>>>>>>
>>>>>>> KIP:
>>>>>>>
>>>>>>>
>>>>>
>>>>
>>>
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-671%3A+Shutdown+Streams+Application+when+appropriate+exception+is+thrown
>>>>>>>
>>>>>>> Discussion thread: *here
>>>>>>> <
>>>>>>>
>>>>>
>>>>
>>>
>> https://mail-archives.apache.org/mod_mbox/kafka-dev/202009.mbox/%3CCAC55fuh3HAGCxz-PzxTJraczy6T-os2oiCV328PBeuJQSVYASg%40mail.gmail.com%3E
>>>>>>>> *
>>>>>>>
>>>>>>> Thanks,
>>>>>>> -Walker
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> -- Guozhang
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>> --
>> -- Guozhang
>>
> 

Mime
View raw message