From dev-return-115367-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Thu Jun 11 20:11:59 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 667B018065E for ; Thu, 11 Jun 2020 22:11:59 +0200 (CEST) Received: (qmail 57582 invoked by uid 500); 11 Jun 2020 20:11:58 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 57570 invoked by uid 99); 11 Jun 2020 20:11:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Jun 2020 20:11:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DF954C03B7 for ; Thu, 11 Jun 2020 20:11:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.199 X-Spam-Level: X-Spam-Status: No, score=-0.199 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent.io Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 4jNXlgd_yPoA for ; Thu, 11 Jun 2020 20:11:52 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::42d; helo=mail-pf1-x42d.google.com; envelope-from=bruno@confluent.io; receiver= Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 140317F876 for ; Thu, 11 Jun 2020 20:11:51 +0000 (UTC) Received: by mail-pf1-x42d.google.com with SMTP id 23so3138442pfw.10 for ; Thu, 11 Jun 2020 13:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=6YpRPwzJe3Cf4NGrSdqfBxA5fjQ3AiqB4QuzEAf6XvM=; b=XEGmVbixV9CjB7q97Mm4muqnyKCcwPb5Jm8pWJG3lK9ZZi/wzmR/Vgpp5ZG/Kz45gF 0k3cDKEVkvhP6GaGzP9kwWzIF9TjWEq+Ac9jitZv5/sZcGfr+ltSt7ZY6C4PAlAjf5Qh Py4bm678QIkavrPmmjpHuHSF/dGLtwRoTAkjAWSQUEJap0j2w09Ee42LW7YKuzCaHuk9 /uiLbN6IcynfMxxTLk53b8LGlUhFcWUf2QClawH9cs/Wjsv3UFnV/1Y+/6GvmLuElGH1 CAwyPhOrC9WiwhwIkmT9R50fDXiR1PrmvREV4ul36d9qvWf788LiqoyhxwmN2rxi/7Dn 8LSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6YpRPwzJe3Cf4NGrSdqfBxA5fjQ3AiqB4QuzEAf6XvM=; b=C0PVpXXFHjqT4tYeAprD8Eloctbp4P3H2KphuDrFGyPre9Jw2BSqhbx//2Hclgj9ZF zP27Ppq+YYlQh9tlLPW0wcrUhC+kiS3s0K1o/87WAfnLcdhzirSxWV7yRlCS+0Lvy5YE BbIYhkqRH30CMYW11YMb2WyBmcQMfLmmCwv0/nGYR1NqU70JBs7mcHj2ACxQBl1yD3Ex dUYzmhzUi4s/GCgFQRotb5jU2PAboptP5zCudkpYua+NqR/Ua6bp4/okiAtB4KO6AXph rKOv+jGdmyuH7pFi/hZ8ju+wmKNSjD0vD73kWH0Zm8W03vuOEAOtOpWxrNELA1YymjC4 SskA== X-Gm-Message-State: AOAM532rzhCRURg7E7y+6Adj2sjbnxojnUXz+HYzyYCnX/2RVpsvUdJB SmjMft7bastP9uEbFAmNdE61XA0IftLaNKqrOhe0H9iXqFX3hQ== X-Google-Smtp-Source: ABdhPJxveKxZebDZxfnITPmcvPPaO42SBqBwrwni0oyH5QuUdMPIck/jmc7cwPUInFFWQj1iLpM61TpeAx18lBD6/M4= X-Received: by 2002:a65:46c9:: with SMTP id n9mr7785328pgr.89.1591906310167; Thu, 11 Jun 2020 13:11:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bruno Cadonna Date: Thu, 11 Jun 2020 22:11:39 +0200 Message-ID: Subject: Re: [DISCUSS] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext To: dev Content-Type: text/plain; charset="UTF-8" Hi Will, Thank you for the KIP. 1. Could you elaborate a bit more on the motivation in the KIP? An example would make the motivation clearer. 2. In section "Proposed Changes" you do not need to show the implementation and describe internals. A description of the expected behavior of the newly added methods should suffice. 3. In "Compatibility, Deprecation, and Migration Plan" you should state that the change is backward compatible because the two methods will be added and no other method will be changed or removed. Best, Bruno On Wed, Jun 10, 2020 at 10:06 AM William Bottrell wrote: > > Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext > > > I am extremely new to Kafka, but thank you to John Roesler and Matthias J. > Sax for pointing me in the right direction. I accept any and all feedback. > > Thanks, > Will