kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeff Kim (Jira)" <j...@apache.org>
Subject [jira] [Created] (KAFKA-10189) Reset metric EventQueueTimeMs
Date Fri, 19 Jun 2020 22:39:00 GMT
Jeff Kim created KAFKA-10189:
--------------------------------

             Summary: Reset metric EventQueueTimeMs 
                 Key: KAFKA-10189
                 URL: https://issues.apache.org/jira/browse/KAFKA-10189
             Project: Kafka
          Issue Type: Bug
          Components: controller, metrics
            Reporter: Jeff Kim
            Assignee: Jeff Kim


The metric [EventQueueTimeMs|[https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/controller/ControllerEventManager.scala#L33]]
does not reset and therefore misrepresents the controller event queue time in these two scenarios:
1. upon losing leader election - `EventQueueTimeMs` portrays the last event queue time of
the previous controller and not the current controller
2. no controller events are added to the queue - `EventQueueTimeMs` portrays the most recent
event queue time, not the current queue time (which is 0)

For both cases, we should reset the controller event queue time to 0.


Implementation:

Instead of using `LinkedBlockingQueue.take()` [here|[https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/controller/ControllerEventManager.scala#L118]],
we can use `LinkedBlockingQueue.poll(long timeout, TimeUnit unit)` and reset `EventQueueTimeMs`
if the queue is empty.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message