kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bruno Cadonna <br...@confluent.io>
Subject Re: [DISCUSS] KIP-622 Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext
Date Thu, 11 Jun 2020 20:11:39 GMT
Hi Will,

Thank you for the KIP.

1. Could you elaborate a bit more on the motivation in the KIP? An
example would make the motivation clearer.

2. In section "Proposed Changes" you do not need to show the
implementation and describe internals. A description of the expected
behavior of the newly added methods should suffice.

3. In "Compatibility, Deprecation, and Migration Plan" you should
state that the change is backward compatible because the two methods
will be added and no other method will be changed or removed.

Best,
Bruno

On Wed, Jun 10, 2020 at 10:06 AM William Bottrell <bottrellw@gmail.com> wrote:
>
> Add currentSystemTimeMs and currentStreamTimeMs to ProcessorContext
> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-622%3A+Add+currentSystemTimeMs+and+currentStreamTimeMs+to+ProcessorContext>
>
> I am extremely new to Kafka, but thank you to John Roesler and Matthias J.
> Sax for pointing me in the right direction. I accept any and all feedback.
>
> Thanks,
> Will

Mime
View raw message