From dev-return-111663-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Wed Feb 26 20:13:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 53B3E18065C for ; Wed, 26 Feb 2020 21:13:03 +0100 (CET) Received: (qmail 84836 invoked by uid 500); 26 Feb 2020 20:13:01 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 84702 invoked by uid 99); 26 Feb 2020 20:13:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Feb 2020 20:13:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D1DE2E3015 for ; Wed, 26 Feb 2020 20:13:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 1CD437802C5 for ; Wed, 26 Feb 2020 20:13:00 +0000 (UTC) Date: Wed, 26 Feb 2020 20:13:00 +0000 (UTC) From: "Guozhang Wang (Jira)" To: dev@kafka.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (KAFKA-9615) Refactor TaskManager to extract task creation / cleanup out of StreamThread MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Guozhang Wang created KAFKA-9615: ------------------------------------ Summary: Refactor TaskManager to extract task creation / cleanup out of StreamThread Key: KAFKA-9615 URL: https://issues.apache.org/jira/browse/KAFKA-9615 Project: Kafka Issue Type: Improvement Reporter: Guozhang Wang Assignee: John Roesler We have a TODO marker for moving the task-creators into the task-manager as a follow-up of the tech cleanup, and here are some rationales: 1. right now the reason we keep the task-creators in stream-thread is to be able to mock task creation in task-manager tests, but that should be better achieved with easy mocks on interfaces than this. 2. the thread only need the thread-producer for a) metrics exposure and b) thread-metadata's producer-client ids. Both of them can be exposed from the task-manager instead of thread-producer. So the idea is that we let the task-manager to abstract / mock the task-creation and manage the producer(s) internally as well, and expose to stream-thread only the metrics / client-ids information upon request. With that it makes more sense to let the creator be the closer of the producer(s) --- i.e. the task-manager, not the stream-producer. And we can fix a couple "FIXMEs" as well along with this effort. -- This message was sent by Atlassian Jira (v8.3.4#803005)