From dev-return-107273-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Fri Sep 6 22:06:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E7846180645 for ; Sat, 7 Sep 2019 00:06:56 +0200 (CEST) Received: (qmail 18207 invoked by uid 500); 7 Sep 2019 10:34:50 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 18188 invoked by uid 99); 7 Sep 2019 10:34:50 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Sep 2019 10:34:50 +0000 Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 98D1E207 for ; Fri, 6 Sep 2019 22:06:55 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailauth.nyi.internal (Postfix) with ESMTP id 6A958220A3 for ; Fri, 6 Sep 2019 18:06:55 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute2.internal (MEProxy); Fri, 06 Sep 2019 18:06:55 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudektddgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtgfesth hqredtreerjeenucfhrhhomhepfdevohhlihhnucfotgevrggsvgdfuceotghmtggtrggs vgesrghprggthhgvrdhorhhgqeenucffohhmrghinheprghprggthhgvrdhorhhgnecurf grrhgrmhepmhgrihhlfhhrohhmpegtmhgttggrsggvfedugedomhgvshhmthhprghuthhh phgvrhhsohhnrghlihhthidqgeeiudekgedufedtqdduheehkeekhedugedqtghmtggtrg gsvgeppegrphgrtghhvgdrohhrghesfhgrshhtmhgrihhlrdgtohhmnecuvehluhhsthgv rhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id EBF28C200A4; Fri, 6 Sep 2019 18:06:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-188-g385deb1-fmstable-20190905v2 Mime-Version: 1.0 Message-Id: <9d2f0a62-2ef1-455c-ab3a-1566c2be3dc9@www.fastmail.com> In-Reply-To: References: <73af9c7e-0c98-470e-ae1e-99c532572b66@www.fastmail.com> <2dc4636f-ff94-42bf-b60d-0ce79742aa3e@www.fastmail.com> Date: Fri, 06 Sep 2019 15:05:49 -0700 From: "Colin McCabe" To: dev@kafka.apache.org Subject: =?UTF-8?Q?Re:_[VOTE]_KIP-482:_The_Kafka_Protocol_should_Support_Optional?= =?UTF-8?Q?_Tagged_Fields?= Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi all, The KIP-482 vote has passed. Thanks to everyone who voted or discussed = the issue. There were 3 non-binding +1 votes from David Jacot, Jose Armando Garcia = Sancio, and Satish Duggana. There were 3 binding +1 votes from Harsha Chintalapani, David Arthur, an= d Jason Gustafson. best, Colin On Fri, Sep 6, 2019, at 13:36, Jason Gustafson wrote: > +1 Thanks Colin. This is really going to help with compatibility. >=20 > -Jason >=20 > On Wed, Sep 4, 2019 at 1:34 PM Colin McCabe wrote= : >=20 > > On Wed, Sep 4, 2019, at 13:01, Jason Gustafson wrote: > > > Hi Colin, > > > > > > Just a couple questions. > > > > > > 1. I think we discussed that we would do a lazy version bump of al= l > > > protocols in order to get flexible version support. Can you add th= at to > > the > > > KIP? > > > > Good point. Added. > > > > > 2. The doc mentions a bump to the request and response header form= ats to > > > version 1. Currently there is no formal header version. It wasn't = clear > > to > > > me if you were suggesting that we create a header version as part = of the > > > schema or if this was just an informal way to refer to the header = in > > > "flexible version" requests. Can you clarify? > > > > I think we should have a formal header version. However, we can ded= uce > > which header version we should use based on the apiKey and apiVersio= n, so > > no changes will be needed to what is sent over the wire. > > > > Having a new header version will let us add new fields to request an= d > > response headers. In particular, having a flexible header version w= ill let > > us add tagged fields, which will be useful for adding things like a = message > > traceID. > > As another example, ThrottleTimeMs would have made more sense in th= e > > response header than as an addition to every message. > > > > cheers, > > Colin > > > > > > > > Thanks, > > > Jason > > > > > > On Wed, Sep 4, 2019 at 8:14 AM David Arthur wro= te: > > > > > > > +1 binding. > > > > > > > > Thanks for the KIP, Colin! > > > > > > > > -David > > > > > > > > On Wed, Sep 4, 2019 at 5:40 AM Harsha Chintalapani > > > > wrote: > > > > > > > > > LGTM. +1 (binding) > > > > > -Harsha > > > > > > > > > > > > > > > On Wed, Sep 04, 2019 at 1:46 AM, Satish Duggana < > > > > satish.duggana@gmail.com> > > > > > wrote: > > > > > > > > > > > +1 (non-binding) Thanks for the nice KIP. > > > > > > > > > > > > You may want to update the KIP saying that optional tagged f= ields > > do > > > > not > > > > > > support complex types(or structs). > > > > > > > > > > > > On Wed, Sep 4, 2019 at 3:43 AM Jose Armando Garcia Sancio > > > > > > wrote: > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Looking forward to this improvement. > > > > > > > > > > > > On Tue, Sep 3, 2019 at 12:49 PM David Jacot > > > > wrote: > > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > Thank for the KIP. Great addition to the Kafka protocol! > > > > > > > > > > > > Best, > > > > > > David > > > > > > > > > > > > Le mar. 3 sept. 2019 =C3=A0 19:17, Colin McCabe a > > > > =C3=A9crit > > > > > : > > > > > > > > > > > > Hi all, > > > > > > > > > > > > I'd like to start the vote for KIP-482: The Kafka Protocol s= hould > > > > Support > > > > > > Optional Tagged Fields. > > > > > > > > > > > > KIP: > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/ > > > > > > KIP-482%3A+The+Kafka+Protocol+should+Support+Optional+Tagged= +Fields > > > > > > > > > > > > Discussion thread here: > > > > > > > > > > > > https://lists.apache.org/thread.html/ > > > > > > cdc801ae886491b73ef7efecac7ef81b24382f8b6b025899ee343f7a@ > > %3Cdev.kafka. > > > > > > apache.org%3E > > > > > > > > > > > > best, > > > > > > Colin > > > > > > > > > > > > -- > > > > > > -Jose > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > David Arthur > > > > > > > > > >