From dev-return-106314-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Tue Aug 6 06:34:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 22A8D180181 for ; Tue, 6 Aug 2019 08:34:47 +0200 (CEST) Received: (qmail 58749 invoked by uid 500); 6 Aug 2019 06:34:44 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 58732 invoked by uid 99); 6 Aug 2019 06:34:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Aug 2019 06:34:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id B8449C14DC for ; Tue, 6 Aug 2019 06:34:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=confluent.io Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id hRhkGNEkhH0S for ; Tue, 6 Aug 2019 06:34:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.217.53; helo=mail-vs1-f53.google.com; envelope-from=cyrus@confluent.io; receiver= Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id 443B4BC806 for ; Tue, 6 Aug 2019 06:34:38 +0000 (UTC) Received: by mail-vs1-f53.google.com with SMTP id u124so57622074vsu.2 for ; Mon, 05 Aug 2019 23:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=confluent.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ffxiDx2foyMTqy304dLnGMu7/GrJ6D0L1Mm/qgYwlOE=; b=Tc0VL6eMuhi0ofh3iMrppocqjLYLybqaqAJ+QWRrOQnHuGENf513HfKD9/qVnY0xwV +Y0DJN3I/ECg6qoeCtDsvDBZB1HkDVZksAlhtx/vL2hjWhWu/JRZ/mFCjXp5eUY5l4JW ejjFEdlZvcQlwfcxZhQzKXZFr57USF4a2n7mDB0rTwJZRP416XIbN77u//FAY/+4yOlx 9AmQmi5aEOoD1nyZtDOhga+Qn174bTvEiDAIeMfZORAByaY1Rq++P1f/PNvVW9ZictuQ P7dxuGRDpRLRkjmRcAk/VLd1A0ND/Oli6IeCOfjfEChOS+dyP06XtfoJAsq2BJTUk+Pj wuHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ffxiDx2foyMTqy304dLnGMu7/GrJ6D0L1Mm/qgYwlOE=; b=DFPgkl93sOL0m+Rw0jAzNMh0aL+t44a+T0B7VehuTguzRK7hn0E02eJcjBCw1IA8vz uDNoUbjO3yDIq5FIxeoCqzhnQcoOPB8uD01MFSwF0XcWKWGae8TaNChbNWMeZeEUlDXv Q93f1TszQFzJFdQXpiywu0Zz3fs4Zh2yiUM9Bs1NIlbnFhlNY7y069S0EAm7GcUBi0oN SPxV/m4ZtpnNmTE/vWyiVrLG91tQ2Weg47rH2qoPHbiEs21EZ3OtnYonTUDDxUYSBMj/ QJSp0YKyLvoyw65022evlRLgR3Yh03mKSsYXkP9NQESWM8857QgrV7Riw0Mn0nYBt+tf iWNQ== X-Gm-Message-State: APjAAAUs0daoORYgoy7n1etRNkeLel77G8x7Ek4WXFD3AyLvJacVOVEZ yNBNDM3hhCSpT/xuVFaDU9RD7lydKHhOGY3p1E20qHsW X-Google-Smtp-Source: APXvYqzOXuRJ0ZMbXniWCpwfbB2CfzVz/NVmBFrRDKK6j5E7N6VX2DnhMcNco3RRuTNMVSgWfn9ZMxTusO/BLamueZ8= X-Received: by 2002:a67:e90c:: with SMTP id c12mr1219991vso.97.1565073271544; Mon, 05 Aug 2019 23:34:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Cyrus Vafadari Date: Mon, 5 Aug 2019 23:34:18 -0700 Message-ID: Subject: Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect To: dev@kafka.apache.org Content-Type: multipart/alternative; boundary="000000000000660252058f6d0441" --000000000000660252058f6d0441 Content-Type: text/plain; charset="UTF-8" This looks like a useful feature, the strategy makes sense, and the KIP is thorough and nicely written. Thanks! Cyrus On Thu, Aug 1, 2019, 12:40 PM Chris Egerton wrote: > Thanks Arjun! Looks good to me. > > On Thu, Aug 1, 2019 at 12:33 PM Arjun Satish > wrote: > > > Thanks for the feedback, Chris! > > > > Yes, the example is pretty much how Connect will use the new feature. > > Tweaked the section to make this more clear. > > > > Best, > > > > On Fri, Jul 26, 2019 at 11:52 AM Chris Egerton > > wrote: > > > > > Hi Arjun, > > > > > > This looks great. The changes to public interface are pretty small and > > > moving the Log4jController class into the clients package seems like > the > > > right way to go. One question I have--it looks like the purpose of this > > KIP > > > is to enable dynamic setting of log levels in the Connect framework, > but > > > it's not clear how the Connect framework will use that new utility. Is > > the > > > "Example Usage" section (which involves invoking the utility with a > > > namespace of "kafka.connect") actually meant to be part of the proposed > > > changes to public interface? > > > > > > Cheers, > > > > > > Chris > > > > > > On Mon, Jul 22, 2019 at 11:03 PM Arjun Satish > > > wrote: > > > > > > > Hi everyone. > > > > > > > > I'd like to propose the following KIP to implement changing log > levels > > on > > > > the fly in Connect workers: > > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-495%3A+Dynamically+Adjust+Log+Levels+in+Connect > > > > > > > > Would like to hear your thoughts on this. > > > > > > > > Thanks very much, > > > > Arjun > > > > > > > > > > --000000000000660252058f6d0441--