kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Gustafson <ja...@confluent.io>
Subject Re: [VOTE] KIP-497: Add inter-broker API to alter ISR
Date Tue, 20 Aug 2019 21:16:09 GMT
Thanks Jun. Yes, that is probably the simplest way to go.

-Jason

On Tue, Aug 20, 2019 at 2:14 PM Jun Rao <jun@confluent.io> wrote:

> Hi, Jason,
>
> Thanks for the KIP. Sorry for the late reply. +1 from me too.
>
> Just a comment on the implementation. Perhaps we should only allow one
> pending AlterIsrRequest from a broker to the controller (at least for a
> given partition) in order to set CurrentZkVersion properly?
>
> Jun
>
> On Tue, Aug 20, 2019 at 10:07 AM Jason Gustafson <jason@confluent.io>
> wrote:
>
> > I'm going to close this vote. The final result is +5 with 3 binding
> votes.
> >
> > -Jason
> >
> > On Wed, Aug 14, 2019 at 10:05 AM Satish Duggana <
> satish.duggana@gmail.com>
> > wrote:
> >
> > > +1 (non-binding), Thanks Jason for nice improvements on ISR
> > > propagation protocol!
> > >
> > > On Wed, Aug 14, 2019 at 8:29 PM David Arthur <mumrah@gmail.com> wrote:
> > > >
> > > > +1 binding, this looks great!
> > > >
> > > > -David
> > > >
> > > > On Tue, Aug 13, 2019 at 4:55 PM Guozhang Wang <wangguoz@gmail.com>
> > > wrote:
> > > >
> > > > > +1 (binding). This is a great KIP, thanks Jason!
> > > > >
> > > > > Regarding the naming of the zkVersion, I'm actually fine to name
it
> > > more
> > > > > generally and leave a note that at the moment its value is defined
> as
> > > the
> > > > > zk version.
> > > > >
> > > > >
> > > > > Guozhang
> > > > >
> > > > >
> > > > > On Mon, Aug 12, 2019 at 2:22 PM Jason Gustafson <
> jason@confluent.io>
> > > > > wrote:
> > > > >
> > > > > > Hi Viktor,
> > > > > >
> > > > > > I originally named the field `CurrentVersion`. I didn't have
'Zk'
> > in
> > > the
> > > > > > name in anticipation of KIP-500. I thought about it and decided
> it
> > > makes
> > > > > > sense to keep naming consistent with other APIs. Even if KIP-500
> > > passes,
> > > > > > there will be some time during which it only refers to the zk
> > > version.
> > > > > > Eventually we'll have to decide whether it makes sense to change
> > the
> > > name
> > > > > > or just introduce a new field.
> > > > > >
> > > > > > Thanks,
> > > > > > Jason
> > > > > >
> > > > > > On Fri, Aug 9, 2019 at 9:19 AM Viktor Somogyi-Vass <
> > > > > > viktorsomogyi@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Hey Jason,
> > > > > > >
> > > > > > > +1 from me too.
> > > > > > > One note though: since it's a new protocol we could perhaps
> > rename
> > > > > > > CurrentZkVersion to something like "IsrEpoch" or "IsrVersion".
> I
> > > think
> > > > > > > that'd reflect its purpose better.
> > > > > > >
> > > > > > > Best,
> > > > > > > Viktor
> > > > > > >
> > > > > > > On Wed, Aug 7, 2019 at 8:37 PM Jason Gustafson <
> > jason@confluent.io
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > Hi All,
> > > > > > > >
> > > > > > > > I'd like to start a vote on KIP-497:
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-497%3A+Add+inter-broker+API+to+alter+ISR
> > > > > > > > .
> > > > > > > > +1
> > > > > > > > from me.
> > > > > > > >
> > > > > > > > -Jason
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > -- Guozhang
> > > > >
> > > >
> > > >
> > > > --
> > > > David Arthur
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message