kafka-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schofield <andrew_schofi...@live.com>
Subject Re: [VOTE] KIP-419: Safely notify Kafka Connect SourceTask is stopped
Date Mon, 05 Aug 2019 13:42:01 GMT
Hi,
I'd like to have a final try at getting some voting on this KIP. I'd like to get it into Kafka
2.4 so get your votes in please.

Currently only +2 non-binding votes.
    
KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-419%3A+Safely+notify+Kafka+Connect+SourceTask+is+stopped
PR: https://github.com/apache/kafka/pull/6551

The idea is that source connectors are multi-threaded and the signal to stop a running connector
can be delivered while messages are being requested from the source system. It's not rocket
science to handle clean up correctly in a connector, but you might need to create a thread
to wait for activity to quieten down so you can do it safely. This KIP just gives a way to
be called by the KC framework when the connector has properly quiesced. Makes the connector
code a bit simpler, and that's particularly helpful for someone just knocking up a simple
connector without worrying about thread management.

Thanks,
Andrew Schofield

On 25/04/2019, 16:11, "Andrew Schofield" <andrew_schofield@live.com> wrote:

    I'd like to encourage some more votes on KIP-419. It's a pretty small KIP to make it easier
to handle resource clean up in Kafka Connect SourceTasks.
    
    Currently only +2 non-binding.
    
    KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-419%3A+Safely+notify+Kafka+Connect+SourceTask+is+stopped
    PR: https://github.com/apache/kafka/pull/6551
    
    Thanks,
    Andrew Schofield
    IBM Event Streams
    
    On 15/04/2019, 15:59, "Edoardo Comar" <ECOMAR@uk.ibm.com> wrote:
    
        Thanks Andrew.
        
        +1 (non-binding)
        
        --------------------------------------------------
        
        Edoardo Comar
        
        IBM Event Streams
        IBM UK Ltd, Hursley Park, SO21 2JN
        
        
        
        
        From:   Mickael Maison <mickael.maison@gmail.com>
        To:     dev <dev@kafka.apache.org>
        Date:   10/04/2019 10:14
        Subject:        Re: [VOTE] KIP-419: Safely notify Kafka Connect SourceTask 
        is stopped
        
        
        
        +1 (non-binding)
        Thanks for the KIP!
        
        On Mon, Apr 8, 2019 at 8:07 PM Andrew Schofield
        <andrew_schofield@live.com> wrote:
        >
        > Hi,
        > I’d like to begin the voting thread for KIP-419. This is a minor KIP to 
        add a new stopped() method to the SourceTask interface in Kafka Connect. 
        Its purpose is to give the task a safe opportunity to clean up its 
        resources, in the knowledge that this is the final call to the task.
        >
        > KIP: 
        https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__cwiki.apache.org_confluence_display_KAFKA_KIP-2D419-253A-2BSafely-2Bnotify-2BKafka-2BConnect-2BSourceTask-2Bis-2Bstopped%26d%3DDwIFaQ%26c%3Djf_iaSHvJObTbx-siA1ZOg%26r%3DEzRhmSah4IHsUZVekRUIINhltZK7U0OaeRo7hgW4_tQ%26m%3DvBvXztcRTgKwMpQ54ziN_GoOo0_fHSvTEMoXwQABvfs%26s%3DParyN6mWVuOGJR7kA84NOshRJA2LAK6htiD2gqf-h_M%26e&amp;data=02%7C01%7C%7Cffb96440b207419a7fcd08d6c1b2ed17%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636909371551269648&amp;sdata=WJ4ZgMEIUTl83QXBIm%2Fn3ekWWabpZTIWsPbQOQGR6J8%3D&amp;reserved=0=
        
        > PR: 
        https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__github.com_apache_kafka_pull_6551%26d%3DDwIFaQ%26c%3Djf_iaSHvJObTbx-siA1ZOg%26r%3DEzRhmSah4IHsUZVekRUIINhltZK7U0OaeRo7hgW4_tQ%26m%3DvBvXztcRTgKwMpQ54ziN_GoOo0_fHSvTEMoXwQABvfs%26s%3DR_udYap1tpd83ISv1Rh0TY6ttH6RuEIwQ0KwOFMB3zU%26e&amp;data=02%7C01%7C%7Cffb96440b207419a7fcd08d6c1b2ed17%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636909371551279653&amp;sdata=4LrcZVcLG9acQm7rjZz8%2F9MO2UeKK08242TW1SSJdlE%3D&amp;reserved=0=
        
        > JIRA: 
        https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Furldefense.proofpoint.com%2Fv2%2Furl%3Fu%3Dhttps-3A__issues.apache.org_jira_browse_KAFKA-2D7841%26d%3DDwIFaQ%26c%3Djf_iaSHvJObTbx-siA1ZOg%26r%3DEzRhmSah4IHsUZVekRUIINhltZK7U0OaeRo7hgW4_tQ%26m%3DvBvXztcRTgKwMpQ54ziN_GoOo0_fHSvTEMoXwQABvfs%26s%3D5WqDQPU2J8yAxRXsjOgydtzJSE8yQCoB7qX0TtQyHA0%26e&amp;data=02%7C01%7C%7Cffb96440b207419a7fcd08d6c1b2ed17%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636909371551279653&amp;sdata=JxRlNBP9FmuCmSVHIj6T30eT3uMPijbHi%2B%2F1QsUfA5U%3D&amp;reserved=0=
        
        >
        > Thanks,
        > Andrew Schofield
        > IBM
        
        
        
        
        Unless stated otherwise above:
        IBM United Kingdom Limited - Registered in England and Wales with number 
        741598. 
        Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
        
        
    
    

Mime
View raw message