From dev-return-105472-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Wed Jul 3 10:36:20 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8FF61180109 for ; Wed, 3 Jul 2019 12:36:20 +0200 (CEST) Received: (qmail 14183 invoked by uid 500); 3 Jul 2019 10:36:04 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 14161 invoked by uid 99); 3 Jul 2019 10:36:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jul 2019 10:36:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9F8E3180D89; Wed, 3 Jul 2019 10:36:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.81 X-Spam-Level: * X-Spam-Status: No, score=1.81 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_PDS_NO_HELO_DNS=0.01] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id U-JZW4qhHEre; Wed, 3 Jul 2019 10:36:02 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::d33; helo=mail-io1-xd33.google.com; envelope-from=manmedia@gmail.com; receiver= Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id A73BE7E208; Wed, 3 Jul 2019 10:36:01 +0000 (UTC) Received: by mail-io1-xd33.google.com with SMTP id k8so3645963iot.1; Wed, 03 Jul 2019 03:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=KK3vGFX0jnzWTTfs7cA++5mG6jXaTLjAZ+kqa0DjQ1k=; b=sO/keoWwL6h5oEbwjoOBzJ7QVTJaX0kf85EY4lDYfagKJxpfh9dv0IA+inpWJfjrl5 WhVXTqtVns450D0fxSODxE6HfnDBSjmyDoqDzgimhbSXBaSX8Iq/HURRobiUSG2jKpPZ xy6CzZ5BE/QBP/YELMaGo7Lo+yYRo/2AvE7jsANRWD3hA46fzErQG5U8SniXuZjHE+IZ N9p9fpHhAtCrLbzO0FjLQLEiSozv1BhdrqneBgkvzSpho2569UMXf3HxQ5F4DGKEh50r zPtiesEfuMe14BcxaPkc8OlCyeX/8tIly/dPYPd4T+6ojMfFzmxxOb16x30fyBYAVYgT JYGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=KK3vGFX0jnzWTTfs7cA++5mG6jXaTLjAZ+kqa0DjQ1k=; b=M/MkNMPjn5aYcI+ADhwrBL97fJW0YmkURsVK6K6I+KvCljKWcx0Tn+CdWp0YA9p8xP HoKA3Z2ZhuTXDgZsvkytdGBTHFySKFHJP/zOuO9AjwfolxpEbEpf6tDgjNoGe3XKhuP2 V7Jb4UUeLOvl56LBXcoSgFSbasT7bsH1WPV2IhccmmsEJbykaP0nc8KsbZ6ihz0aYNf7 ZXnLA4M/B0elhHO8zpVM4uuERBM6pBX81POO+EJuEOWWl1AluGE25hVsBpmdGNbLUUKc MqbOOAn+eNzsjzDCqmc7rmW8vsqeV+wOWeBlnwWQpqI7aroURYcyWINBut73PweeqblC Sz2g== X-Gm-Message-State: APjAAAVgslN5j0kTSK3dIbpPWvEO1780AlTm/TyCfSnR2YtPGtNJAiLE SswrxSA3XzPBFdU2lUFbl+Ui2QLc/Nizxo/+sPvB8fd4 X-Google-Smtp-Source: APXvYqzzR0tOPGSXOj/zlswIOO1chIki6eHE3PQwqtw+Kx+40tDGst21DdYvaDRl1sq24dbcjNumotwHzr59eDiBS44= X-Received: by 2002:a5d:8ccc:: with SMTP id k12mr6489583iot.141.1562150160165; Wed, 03 Jul 2019 03:36:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "M. Manna" Date: Wed, 3 Jul 2019 11:35:49 +0100 Message-ID: Subject: Re: PR review To: dev@kafka.apache.org, Kafka Users Content-Type: multipart/alternative; boundary="00000000000061f204058cc46d00" --00000000000061f204058cc46d00 Content-Type: text/plain; charset="UTF-8" https://github.com/apache/kafka/pull/6771 Bouncing both users and dev to get some activity going. We are waiting for a while to get this KIP pr merged. Could someone please review? Thanks, On Sun, 30 Jun 2019 at 08:59, M. Manna wrote: > https://github.com/apache/kafka/pull/6771 > > Hello, > > Could the above PR can be reviewed? This has been waiting for a long time. > > Just to mention, the package name should have "internal". Round-robin > partitioning should have been supported without/without a key from the > beginning. It provides user a guaranteed round-robin partitioning without > having to regard for key values (e.g. null/not null). From our business > side, this is a Kafka internal logic. Hence, the placement inside > "internal" package. > > Thanks, > --00000000000061f204058cc46d00--