From dev-return-105526-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Mon Jul 8 21:38:43 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 53B40180665 for ; Mon, 8 Jul 2019 23:38:43 +0200 (CEST) Received: (qmail 42302 invoked by uid 500); 8 Jul 2019 21:38:30 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 42278 invoked by uid 99); 8 Jul 2019 21:38:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jul 2019 21:38:30 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0C5DD180DEA; Mon, 8 Jul 2019 21:38:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.127 X-Spam-Level: *** X-Spam-Status: No, score=3.127 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, PDS_NO_HELO_DNS=1.327, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 365hoTCJq9nA; Mon, 8 Jul 2019 21:38:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::d2d; helo=mail-io1-xd2d.google.com; envelope-from=manmedia@gmail.com; receiver= Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id D8B207E210; Mon, 8 Jul 2019 21:38:27 +0000 (UTC) Received: by mail-io1-xd2d.google.com with SMTP id m24so29203075ioo.2; Mon, 08 Jul 2019 14:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=lHkpO1FIy6ExUa7zWrKo19QsXewi3pVy9vM8lwONw58=; b=WaWVX+BQECJBBqNCH18COqwkIxMDw2uuxjS5gbt1XERMLjbb7D7slmmL0VuLFqBuaq 6rNuGj8UdaUcl2AM6fIwAuP0SiQib/vRnzE1tF3aPxl6F/WpOSGG9kuF7wqvammLypuD Y3H7J8csVc6hB/+j55QYB9vRNU/AfVx2JD5UKbPMn192oAQi2q2m8HwMBvzzEmUGB/0x XX2GFzMk2j7KxiXo7l5ra9z5eAfngOTU9WGd3SjpzYaTSF6Kcvm+X+Wv/TggWfd5qLgw Puso6aQBmO49GV0+dt5I0x0iE1/+Bsts4KcEmiINCHq6zdg6yHo5nqZmrTaq9IoXb0rs 60Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=lHkpO1FIy6ExUa7zWrKo19QsXewi3pVy9vM8lwONw58=; b=iW1Kyij04LEKJgpd0wkpcFXAfl3umutiA2+8rEgvfdByhZMMBxwWx5ZgHRbYrH3Tz6 RDBHDn9zlhYV1ikzV9iCVHoEMp60z92gzuSpF2IUQp2KDit3DVZLG3gnPtWYeiL5eO5s BOBKHSi184lCaP7x0X+PbvKfhOFwHMX4NFSvQmBI6GmEsPE8J37Wb66gmpg6jMzbUtWt OtRRk8PQlxBgbpC56Cs/rYGxOO3rtuuIgaStEfqN+mjznoxbEARUy3ntYMnDUsXnlK+O dtX9nUDYL8LNSsl6hAgvoNaZAohvozrWV/Mf0qLAOWkUiYvu1+W+CbHqFAesBiSe2w4L 82hw== X-Gm-Message-State: APjAAAX8hdJVI581i+y5swieGAnXDRxOE3Vw29ubkSwrtXTuXSwxw/o6 DBogF7BAy3wWhlBydNNqHAEUXmX8Is/L1REHoV23VQLl X-Google-Smtp-Source: APXvYqwHGjObb+s5v5tkmfdmnJOd0VKErehA9x6GteeR4HhnqRAHc3Y1eqBxbl0IpoUezwDG+AZz80idRuoXWmP2MlU= X-Received: by 2002:a05:6602:2183:: with SMTP id b3mr4483393iob.249.1562621906206; Mon, 08 Jul 2019 14:38:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "M. Manna" Date: Mon, 8 Jul 2019 22:38:15 +0100 Message-ID: Subject: Re: PR review To: Kafka Users , dev@kafka.apache.org Content-Type: multipart/alternative; boundary="000000000000a34714058d324329" --000000000000a34714058d324329 Content-Type: text/plain; charset="UTF-8" Hello, A few requests have been sent already. Could this please be reviewed ? Our business implementation is holding due to this change. On Thu, 4 Jul 2019 at 13:33, M. Manna wrote: > https://github.com/apache/kafka/pull/6771 > > Could this be reviewed please ? > > On Wed, 3 Jul 2019 at 11:35, M. Manna wrote: > >> https://github.com/apache/kafka/pull/6771 >> >> Bouncing both users and dev to get some activity going. We are waiting >> for a while to get this KIP pr merged. >> >> Could someone please review? >> >> Thanks, >> >> On Sun, 30 Jun 2019 at 08:59, M. Manna wrote: >> >>> https://github.com/apache/kafka/pull/6771 >>> >>> Hello, >>> >>> Could the above PR can be reviewed? This has been waiting for a long >>> time. >>> >>> Just to mention, the package name should have "internal". Round-robin >>> partitioning should have been supported without/without a key from the >>> beginning. It provides user a guaranteed round-robin partitioning without >>> having to regard for key values (e.g. null/not null). From our business >>> side, this is a Kafka internal logic. Hence, the placement inside >>> "internal" package. >>> >>> Thanks, >>> >> --000000000000a34714058d324329--