From dev-return-105638-archive-asf-public=cust-asf.ponee.io@kafka.apache.org Fri Jul 12 00:26:11 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AC4DF1804BB for ; Fri, 12 Jul 2019 02:26:10 +0200 (CEST) Received: (qmail 41020 invoked by uid 500); 12 Jul 2019 00:26:08 -0000 Mailing-List: contact dev-help@kafka.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kafka.apache.org Delivered-To: mailing list dev@kafka.apache.org Received: (qmail 41008 invoked by uid 99); 12 Jul 2019 00:26:08 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jul 2019 00:26:08 +0000 Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 0DA3E8224 for ; Fri, 12 Jul 2019 00:26:08 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailauth.nyi.internal (Postfix) with ESMTP id B44EC220F4 for ; Thu, 11 Jul 2019 20:26:07 -0400 (EDT) Received: from imap1 ([10.202.2.51]) by compute2.internal (MEProxy); Thu, 11 Jul 2019 20:26:07 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrgeelgdefhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgesthdtre dtreertdenucfhrhhomhepfdevohhlihhnucfotgevrggsvgdfuceotghmtggtrggsvges rghprggthhgvrdhorhhgqeenucffohhmrghinheprghprggthhgvrdhorhhgnecurfgrrh grmhepmhgrihhlfhhrohhmpegtmhgttggrsggvfedugedomhgvshhmthhprghuthhhphgv rhhsohhnrghlihhthidqgeeiudekgedufedtqdduheehkeekhedugedqtghmtggtrggsvg eppegrphgrtghhvgdrohhrghesfhgrshhtmhgrihhlrdgtohhmnecuvehluhhsthgvrhfu ihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 6D69DC200A4; Thu, 11 Jul 2019 20:26:07 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-731-g19d3b16-fmstable-20190627v1 Mime-Version: 1.0 Message-Id: <608f6ad1-ad76-46be-bbde-642e6ffa6696@www.fastmail.com> In-Reply-To: References: Date: Thu, 11 Jul 2019 17:25:33 -0700 From: "Colin McCabe" To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-480 : Sticky Partitioner Content-Type: text/plain +1 (binding). Thanks, Justine! ComputedPartition#get probably should be ComputedPartition#partition or something. We typically name accessors the same as the variables that are being accessed. As we discussed in the other thread, one minor addition that might make this KIP even better is a StickyRoundRobinPartitioner class that just implements the sticky behavior regardless of whether the key is null or not. It would just be a standalone custom partitioner class that could be configured if people wanted this. best, Colin On Tue, Jul 9, 2019, at 17:15, Justine Olshan wrote: > Hello all, > > I'd like to start the vote for KIP-480 : Sticky Partitioner. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-480%3A+Sticky+Partitioner > > Thank you, > Justine Olshan >